-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add individual project refresh with progress notification #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat: add individual project refresh with progress notification #6
Conversation
Enhance updateClasspaths to support refreshing individual projects with improved user feedback and BUILD file detection: - Add progress notification during classpath refresh - Support refreshing from specific BUILD file, active editor, or parent directories - Improve error handling with informative messages - Pass Uri objects instead of paths for better type safety - Add tests for updateClasspaths command registration - Update extension ID to COMP.java-bazel-extension Signed-off-by: runchen0919 <[email protected]>
| this.treeData = resp.data.map((cp) => { | ||
| const moduleBuildFile = getModuleBuildFile(cp.path); | ||
| const moduleBuildFilePath = getModuleBuildFile(cp.path); | ||
| const moduleBuildFileUri = Uri.file(moduleBuildFilePath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unified parameter passing type
| progress.report({ message: 'Updating classpath from BUILD file...' }); | ||
|
|
||
| try { | ||
| await executeJavaLanguageServerCommand( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a backend call to refresh the classpath from the built file to enable project-wide refresh functionality.
| suiteSetup(async function () { | ||
| try { | ||
| await extensions.getExtension('sfdc-eng.bazel-java')?.activate(); | ||
| await extensions.getExtension('COMP.java-bazel-extension')?.activate(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the unit test; the name here must match the plugin name.
zhirui1994
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Enhance updateClasspaths to support refreshing individual projects with improved user feedback and BUILD file detection: