[Appservice] Fix #31394: az functionapp deployment source config-zip: never ending loop on flex function app health check#33388
Open
dylan8902 wants to merge 1 commit into
Open
Conversation
Adds missing tries count Breaks out if IP restriction in place
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
dylan8902
changed the title
az functionapp deployment source config-zip: never ending loop on flex function app health check
dylan8902
requested review from
NoriZC,
teresaritorto and
yanzhudd
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a hang in the App Service module’s post-deployment health check for Flex Function Apps invoked by az functionapp deployment source config-zip, by ensuring the retry loop terminates and by short-circuiting when the health check is blocked by IP restrictions.
Changes:
- Increment
num_trialsfor non-2xx health-check responses to prevent an infinite retry loop. - Exit the health-check loop early when a 403 response indicates IP-based access restriction.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| break | ||
| if response.status_code == 403 and response.reason == 'Ip Forbidden': | ||
| logger.warning("Failed to check health due to IP restriction") | ||
| break |
Comment on lines
+825
to
+828
| if response.status_code == 403 and response.reason == 'Ip Forbidden': | ||
| logger.warning("Failed to check health due to IP restriction") | ||
| break | ||
| num_trials = num_trials + 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az functionapp deployment source config-zip
Description
The
check_flex_app_after_deploymentfunction called after a deployment had a never ending re-try loop for non-2xx response status codes. This PR adds the missingnum_trialsincrement. It also breaks out of the health check when an IP restriction is found preventing the health check to complete from the client.Testing Guide
An existing function app with a default network rule of Deny has no access from the client to the app. Run the deployment command:
az functionapp deployment source config-zip \ --resource-group MyResourceGroup \ --name MyUniqueAppName \ --src funcapp.zipBefore it would hang forever, but now transient errors are handled and retries are done up the the limit.
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.