Skip to content

[Appservice] Fix #31394: az functionapp deployment source config-zip: Never ending loop on flex function app health check #33388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dylan8902 wants to merge 2 commits into
base: dev
Choose a base branch
from
+113 −1
Open

[Appservice] Fix #31394: az functionapp deployment source config-zip: Never ending loop on flex function app health check #33388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a61c965
Fixes never ending loop on flex function app health check
dylan8902 May 17, 2026
915b9cc
Return on IP restriction and add unit tests for the flex deployment c…
dylan8902 May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/azure-cli/azure/cli/command_modules/appservice/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,9 @@ def check_flex_app_after_deployment(cmd, resource_group_name, name):
verify=not should_disable_connection_verify())
if 200 <= response.status_code <= 299:
break
if response.status_code == 403 and response.reason == 'Ip Forbidden':
return "Deployment was successful but health check failed due to IP restriction."
num_trials = num_trials + 1
Comment thread
dylan8902 marked this conversation as resolved.

if response.status_code != 200:
raise CLIError("Deployment was successful but the app appears to be unhealthy. Please "
Expand Down
111 changes: 110 additions & 1 deletion .../azure/cli/command_modules/appservice/tests/latest/test_functionapp_commands_thru_mock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,15 @@
enable_zip_deploy_functionapp,
enable_zip_deploy,
enable_zip_deploy_flex,
check_flex_app_after_deployment,
add_remote_build_app_settings,
remove_remote_build_app_settings,
config_source_control,
validate_app_settings_in_scm,
update_container_settings_functionapp)
from azure.cli.core.profiles import ResourceType
from azure.cli.core.azclierror import (AzureInternalError, UnclassifiedUserFault)
from azure.cli.core.azclierror import ResourceNotFoundError

TEST_DIR = os.path.abspath(os.path.join(os.path.abspath(__file__), '..'))

Expand Down Expand Up @@ -253,6 +255,113 @@ def test_enable_zip_deploy_flex(self,
check_zip_deployment_status_mock.assert_called_with(cmd_mock, 'rg', 'name',
'https://mock-scm/api/deployments/latest', None)

@mock.patch('time.sleep')
@mock.patch('requests.get', autospec=True)
@mock.patch('azure.cli.core.util.should_disable_connection_verify', return_value=False)
@mock.patch('azure.cli.command_modules.appservice.custom.list_host_keys')
@mock.patch('azure.cli.command_modules.appservice.custom._get_host_url',
return_value='https://mock-func.azurewebsites.net')
def test_check_flex_app_after_deployment_success(self,
get_host_url_mock,
list_host_keys_mock,
should_disable_verify_mock,
requests_get_mock,
sleep_mock):
# prepare
cmd_mock = _get_test_cmd()
list_host_keys_mock.return_value = mock.Mock(master_key='master-key')
response = mock.Mock(status_code=200, reason='OK')
requests_get_mock.return_value = response

# action
result = check_flex_app_after_deployment(cmd_mock, 'rg', 'name')

# assert
self.assertEqual(result, "Deployment was successful.")
requests_get_mock.assert_called_with('https://mock-func.azurewebsites.net/admin/host/status',
headers={"x-functions-key": 'master-key'},
verify=True)

@mock.patch('time.sleep')
@mock.patch('azure.cli.command_modules.appservice.custom._get_host_url', side_effect=ValueError())
def test_check_flex_app_after_deployment_host_url_fetch_failure(self,
get_host_url_mock,
sleep_mock):
# prepare
cmd_mock = _get_test_cmd()

# action
with self.assertRaises(ResourceNotFoundError):
check_flex_app_after_deployment(cmd_mock, 'rg', 'name')

# assert
get_host_url_mock.assert_called_once_with(cmd_mock, 'rg', 'name')

@mock.patch('time.sleep')
@mock.patch('azure.cli.command_modules.appservice.custom.list_host_keys', side_effect=Exception())
@mock.patch('azure.cli.command_modules.appservice.custom._get_host_url',
return_value='https://mock-func.azurewebsites.net')
def test_check_flex_app_after_deployment_host_key_fetch_failure(self,
get_host_url_mock,
list_host_keys_mock,
sleep_mock):
# prepare
cmd_mock = _get_test_cmd()

# action
with self.assertRaises(ResourceNotFoundError):
check_flex_app_after_deployment(cmd_mock, 'rg', 'name')

# assert
list_host_keys_mock.assert_called_once_with(cmd_mock, 'rg', 'name')

@mock.patch('time.sleep')
@mock.patch('requests.get', autospec=True)
@mock.patch('azure.cli.core.util.should_disable_connection_verify', return_value=False)
@mock.patch('azure.cli.command_modules.appservice.custom.list_host_keys')
@mock.patch('azure.cli.command_modules.appservice.custom._get_host_url',
return_value='https://mock-func.azurewebsites.net')
def test_check_flex_app_after_deployment_ip_restriction(self,
get_host_url_mock,
list_host_keys_mock,
should_disable_verify_mock,
requests_get_mock,
sleep_mock):
# prepare
cmd_mock = _get_test_cmd()
list_host_keys_mock.return_value = mock.Mock(master_key='master-key')
requests_get_mock.return_value = mock.Mock(status_code=403, reason='Ip Forbidden')

# action
result = check_flex_app_after_deployment(cmd_mock, 'rg', 'name')

# assert
self.assertEqual(result, "Deployment was successful but health check failed due to IP restriction.")

@mock.patch('time.sleep')
@mock.patch('requests.get', autospec=True)
@mock.patch('azure.cli.core.util.should_disable_connection_verify', return_value=False)
@mock.patch('azure.cli.command_modules.appservice.custom.list_host_keys')
@mock.patch('azure.cli.command_modules.appservice.custom._get_host_url',
return_value='https://mock-func.azurewebsites.net')
def test_check_flex_app_after_deployment_unhealthy(self,
get_host_url_mock,
list_host_keys_mock,
should_disable_verify_mock,
requests_get_mock,
sleep_mock):
# prepare
cmd_mock = _get_test_cmd()
list_host_keys_mock.return_value = mock.Mock(master_key='master-key')
requests_get_mock.return_value = mock.Mock(status_code=500, reason='Internal Server Error')

# action
with self.assertRaises(CLIError):
check_flex_app_after_deployment(cmd_mock, 'rg', 'name')

# assert
self.assertEqual(requests_get_mock.call_count, 15)


@mock.patch('azure.cli.command_modules.appservice.custom.get_scm_site_headers')
@mock.patch('azure.cli.command_modules.appservice.custom._get_scm_url', side_effect=ValueError())
Expand Down Expand Up @@ -494,7 +603,7 @@ def test_update_container_settings_functionapp(self,
Site, DaprConfig, ResourceConfig = cmd_mock.get_models('Site', 'DaprConfig', 'ResourceConfig')
site = Site(dapr_config=None, location='westus', name='name', resource_config=ResourceConfig())
site_op_mock.return_value = site

is_centauri_functionapp_mock.return_value = True

check_language_runtime_mock.return_value = True
Expand Down
Loading