Conversation
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
fbe8104 to
974ac94
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
974ac94 to
15d1ae0
Compare
DaanV2
reviewed
Mar 8, 2026
Comment on lines
-3
to
-7
| export const PotionTypes: string[] = [ | ||
| "Consume", | ||
| "ThrownLingering", | ||
| "ThrownSplash" | ||
| ]; No newline at end of file |
Contributor
There was a problem hiding this comment.
@copilot Can you ensure that there is a base file where we can define these values, so they aren't removed during scraping
Contributor
… across scrapes (#271) The scraper was overwriting `potion_types.ts` with an empty array on each run because `General` had no base-loading mechanism — unlike BP/RP containers which seed from `src/base/` before scraping. ## Changes - **New base JSON files** in `packages/bedrock-vanilla-data/src/base/general/`: - `potion_types.json` — seeds the known values `["Consume", "ThrownLingering", "ThrownSplash"]` - `potion_modifiers.json` — empty placeholder following the same pattern - **`General.load(folder)`** — new static method on the `General` class that reads base values from JSON files before scraping populates the rest - **`Output.load()`** — updated to call `General.load(baseFolder/general)` alongside the existing `edu`/`vanilla` OutputSet loads - **`loadStringArray(filepath)`** — new helper in `json.ts` for loading plain string arrays; `loadEnsure<string>` silently wraps string items into `{ id }` objects (by design for BP/RP data), which is incorrect for simple string fields on `General` The flow is now consistent with BP/RP containers: base values are loaded first, scraped values are merged on top, and `cleanStrings()` deduplicates before saving. <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/Blockception/minecraft-bedrock-language-server/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: DaanV2 <2393905+DaanV2@users.noreply.github.com>
DaanV2
requested changes
Mar 12, 2026
DaanV2
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action