Add base file support for general data to preserve potion type values across scrapes#271
Merged
DaanV2 merged 2 commits intocreate-pull-request/patchfrom Mar 9, 2026
Merged
Conversation
… potion types Co-authored-by: DaanV2 <2393905+DaanV2@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on base file for scraped data values retention
Add base file support for general data to preserve potion type values across scrapes
Mar 8, 2026
DaanV2
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scraper was overwriting
potion_types.tswith an empty array on each run becauseGeneralhad no base-loading mechanism — unlike BP/RP containers which seed fromsrc/base/before scraping.Changes
New base JSON files in
packages/bedrock-vanilla-data/src/base/general/:potion_types.json— seeds the known values["Consume", "ThrownLingering", "ThrownSplash"]potion_modifiers.json— empty placeholder following the same patternGeneral.load(folder)— new static method on theGeneralclass that reads base values from JSON files before scraping populates the restOutput.load()— updated to callGeneral.load(baseFolder/general)alongside the existingedu/vanillaOutputSet loadsloadStringArray(filepath)— new helper injson.tsfor loading plain string arrays;loadEnsure<string>silently wraps string items into{ id }objects (by design for BP/RP data), which is incorrect for simple string fields onGeneralThe flow is now consistent with BP/RP containers: base values are loaded first, scraped values are merged on top, and
cleanStrings()deduplicates before saving.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.