feat(reports): preserve unexplained-leftover comparison delta pending successor verification - #832
Draft
seonghobae wants to merge 1 commit into
Conversation
…on strip (v2.54.0) Caption persisted leftover-map unexplained leftover U = R − R̂ on grouping comparison leftover-pair buttons through formatLeftoverMapUnexplained (ADR 0297). Distinct aria-label Leftover map comparison unexplained leftover. Missing or non-finite U omits that badge and keeps x, s, e, R̂, d, and coverage notes. Do not invent U from R and R̂. Rank-0 origin cells still name U 0.00 when finite. Finite negative leftover is shown, never clamped. UI-only; no new columns.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This was referenced Aug 30, 2026
feat(reports): preserve grouping-comparison unexplained-leftover delta for serialized successor
#833
Draft
seonghobae
changed the title
seonghobae
marked this pull request as draft
September 7, 2026 08:16
seonghobae
added
enhancement
ChatGPT Codex Connector
This was referenced Sep 11, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovery status
This PR remains an open Draft recovery/evidence lane. Historical head
1511166c53c16fef65f3330eee58d3a5664b1583introduced a valid persisted grouping-comparison unexplained-leftoverUpresentation delta, helper/i18n/App regressions, ADR0297 evidence, release metadata, and generated-lock version change. It was previously closed before complete successor inheritance was proven, so keep it open under the no-drop rule. Do not merge this historical head or resume product source writing here.Current serialized prerequisite
The live prefix is #828
ac386f981317144a98a0878ca0f13c7731f7cacc→ #82923519e93f0203ebaf9666f60e5eb7e6368dd6219→ #830bebd77c03e5beae469f42361c20bccc80787ebb5→ #83193e1b4fb5601b5733e9a4b0f7b4a9f63ff44354e.#1010 completed exact-head Tests
34612342413GREEN and normally merged into #831. Fresh #831 Tests34614827175is now terminal SUCCESS on the moved exact head: frontend/browser job103314015764passed authenticated startup, seed, signed fixture pin and browser acceptance, and PostgreSQL/full-suite job103314016038passed the complete repository suite. #831 has therefore returned to Draft after validation admission; its test/browser receipt does not make the still-Draft ancestor chain promotable by itself.This PR's GitHub base metadata points to the current #831 branch at exact
93e1b4fb...; its own head remains historical recovery evidence and is intentionally conflicting rather than destructively rewritten.#833 successor inheritance
#833 is the intended live successor for the
Uproduct behavior. Reconstruction must preserve every valid delta from this lane: finite/missing/non-finite/negative/zero persisted-Usemantics; helper/i18n/App regressions; the assertion thatLEFTOVER_MAP_COMPARE_UNEXPLAINED_LABELremains distinct from the unexplained-share label; generated-lock/project-version parity by regeneration rather than hand edits; and all valid fixture/contract/evidence. Historical ADR0297/v2.54.0 is evidence only because current #828 owns v2.54.0.Do not reconstruct product source on this recovery lane. #833 may reconstruct non-force only after the exact #831 acceptance above is combined with an actually promotable ancestor chain under its own current-head gates. It must then explicitly inherit every valid #832 delta before this recovery PR can close.
Close criterion
Close only after exact reconstructed #833 proves complete inheritance, current collision-free ADR/release identity, regenerated lock parity, and fresh exact-head required checks. Until then this PR remains Draft recovery authority. No force-push, destructive rebase, self-approval, gate weakening, source duplication, psychometric recomputation, ancestor bypass, or stale-head evidence transfer.