Skip to content

fix(agent-installer): backfill Agent Tunnel localization strings to JSON#1801

Merged
Benoît Cortier (CBenoit) merged 1 commit into
masterfrom
fix/agent-installer-localization-backfill
May 27, 2026
Merged

fix(agent-installer): backfill Agent Tunnel localization strings to JSON#1801
Benoît Cortier (CBenoit) merged 1 commit into
masterfrom
fix/agent-installer-localization-backfill

Conversation

@irvingoujAtDevolution
Copy link
Copy Markdown
Contributor

Summary

The 11 Agent Tunnel localization strings added in #1789 were hand-edited directly into the generated .wxl files without corresponding entries in the JSON sources (Strings_en-US.json / Strings_fr-FR.json). The next Strings.g.tt regeneration would silently delete them — exactly the failure mode Richard flagged.

This backfills all 11 keys to both JSON sources and regenerates.

Review note

  • Real change: JSON sources (+11 each) and the 11 new Strings.g.cs constants.
  • The .wxl diffs are pure reordering — the generator sorts by Id within each group. Id set vs master is +0/-0 (no keys added/removed, no text changed); those keys already existed in the .wxl.
  • Regenerated via VS "Run Custom Tool" on Strings.g.tt.

No user-visible change.

Changelog: ignore

The 11 Agent Tunnel strings from #1789 were edited directly into the
.wxl files with no JSON source entries, so the next Strings.g.tt
regeneration would silently delete them. Backfill to Strings_en-US/
fr-FR.json and regenerate (.wxl diffs are pure reordering).

Changelog: ignore
@github-actions
Copy link
Copy Markdown

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

Copy link
Copy Markdown
Member

@CBenoit Benoît Cortier (CBenoit) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@CBenoit Benoît Cortier (CBenoit) merged commit 0d1ea25 into master May 27, 2026
44 checks passed
@CBenoit Benoît Cortier (CBenoit) deleted the fix/agent-installer-localization-backfill branch May 27, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants