fix(pivotGrid): Fix error thrown opening date pivot dimension filter. - #17481
Open
skrustev wants to merge 3 commits into
Open
fix(pivotGrid): Fix error thrown opening date pivot dimension filter.#17481skrustev wants to merge 3 commits into
skrustev wants to merge 3 commits into
Conversation
skrustev
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Pivot Grid error triggered when opening the Pivot Date Dimension Excel-style filter by adjusting how the grid reacts to i18n resource change events, and removes the temporary test-only workaround that was masking the issue.
Changes:
- Defer
setupColumns()execution on i18nonResourceChangeto avoid the runtime error when the filter opens. - Remove the
getI18nManager().removeAllListeners()test workaround and its import now that the underlying issue is addressed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.ts | Defers column regeneration on i18n resource changes to prevent the filter-opening error. |
| projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.spec.ts | Removes the prior workaround that cleared i18n listeners in tests. |
dkamburov
added
💥 status: in-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#17478
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)