Skip to content

fix(pivotGrid): Fix error thrown opening date pivot dimension filter. #17481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skrustev wants to merge 3 commits into
base: 21.2.x
Choose a base branch
from
+3 −11
Open

fix(pivotGrid): Fix error thrown opening date pivot dimension filter. #17481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8a6c99
fix(pivotGrid): Fix error thrown opening date pivot dimension filter.
skrustev Aug 3, 2026
cd1c41a
test(pivotGrid): Fix tests with workaround of the issue.
skrustev Aug 3, 2026
8b24ad6
chore(*): Remove unused import
skrustev Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,7 +998,9 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
onResourceChangeHandle(this.destroy$, () => {
this.setDateDimensionsLocaleData();
// Since the columns are kinda static, due to assigning DisplayName on init, they need to be regenerated.
this.setupColumns();
Promise.resolve().then(() => {
this.setupColumns();
});
}, this);
});
if (this.valueChipTemplateDirective) {
Expand Down
10 changes: 0 additions & 10 deletions projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import { IgxPivotRowDimensionContentComponent } from './pivot-row-dimension-cont
import { IgxPivotGridComponent } from './pivot-grid.component';
import { IgxGridCell } from 'igniteui-angular/grids/core';
import { IGridCellEventArgs } from 'igniteui-angular/grids/core';
import { getI18nManager } from 'igniteui-i18n-core';

const CSS_CLASS_LIST = 'igx-drop-down__list';
const CSS_CLASS_ITEM = 'igx-drop-down__item';
Expand Down Expand Up @@ -843,9 +842,6 @@ describe('IgxPivotGrid #pivotGrid', () => {

describe('IgxPivotGrid Features #pivotGrid', () => {
it('should show excel style filtering via dimension chip.', async () => {
// Weird angular error caused by calling setupColumns() on opening a filter. Disable it for now.
(getI18nManager() as any).removeAllListeners();

const pivotGrid = fixture.componentInstance.pivotGrid;
expect(pivotGrid.filterStrategy).toBeInstanceOf(DimensionValuesFilteringStrategy);
const excelMenu = GridFunctions.getExcelStyleFilteringComponents(fixture, 'igx-pivot-grid')[1];
Expand Down Expand Up @@ -879,9 +875,6 @@ describe('IgxPivotGrid #pivotGrid', () => {
});

it('should filter rows via excel style filtering dimension chip.', async () => {
// Weird angular error caused by calling setupColumns() on opening a filter. Disable it for now.
(getI18nManager() as any).removeAllListeners();

const pivotGrid = fixture.componentInstance.pivotGrid;
const headerRow = fixture.nativeElement.querySelector('igx-pivot-header-row');
const rowChip = headerRow.querySelector('igx-chip[id="All"]');
Expand Down Expand Up @@ -1126,9 +1119,6 @@ describe('IgxPivotGrid #pivotGrid', () => {
});

it('should show complex tree and allow filtering for Date dimension', async () => {
// Weird angular error caused by calling setupColumns() on opening a filter. Disable it for now.
(getI18nManager() as any).removeAllListeners();

const pivotGrid = fixture.componentInstance.pivotGrid;
pivotGrid.pivotConfiguration.rows = [new IgxPivotDateDimension(
{
Expand Down
Loading