Skip to content

Restore decrement!, which the SuiteSparse stdlib binds - #1172

Closed
ViralBShah wants to merge 1 commit into
release-1.14from
restore-decrement-1.14
Closed

ViralBShah wants to merge 1 commit into
release-1.14from
restore-decrement-1.14

Conversation

@ViralBShah

Copy link
Copy Markdown
Member

#1169 removed decrement! because nothing in this package calls it, and #1170 backported that to release-1.14. But JuliaSparse/SuiteSparse.jl, which Julia ships as a stdlib, binds const decrement! = SparseArrays.decrement! at load time, so the bump in JuliaLang/julia#64953 fails to build on every platform:

Before

ERROR: LoadError: UndefVarError: `decrement!` not defined in `SparseArrays`
  @ .../stdlib/v1.14/SuiteSparse/src/SuiteSparse.jl:9
✗ SuiteSparse

After: SuiteSparse loads.

This restores the method unchanged, with a comment naming its user, and adds a test that every name SuiteSparse.jl binds exists. Unblocks Base CI: the 1.14 bump needs re-running on this commit. The same change is needed on main before its next bump; that PR follows.

🤖 Generated with Claude Code

#1169 removed `decrement!` because nothing in this package calls it, but
JuliaSparse/SuiteSparse.jl, which Julia ships as a stdlib, does
`const decrement! = SparseArrays.decrement!` at load time. Without it
SuiteSparse fails to precompile and Julia's build stops.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.88%. Comparing base (c3f953d) to head (cdfd52d).

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.14    #1172   +/-   ##
=============================================
  Coverage         98.88%   98.88%           
=============================================
  Files                16       16           
  Lines             10601    10604    +3     
=============================================
+ Hits              10483    10486    +3     
  Misses              118      118           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ViralBShah added a commit that referenced this pull request Nov 14, 2026
#1169 removed `decrement!` because nothing in this package calls it. But
JuliaSparse/SuiteSparse.jl, which Julia ships as a stdlib, binds `const
decrement! = SparseArrays.decrement!` at load time, so a bump that
includes #1169 fails to build Julia on every platform, as in
JuliaLang/julia#64953:

**Before**
```
ERROR: LoadError: UndefVarError: `decrement!` not defined in `SparseArrays`
  @ .../stdlib/v1.14/SuiteSparse/src/SuiteSparse.jl:9
✗ SuiteSparse
```

**After**: SuiteSparse loads.

This restores the method unchanged, with a comment naming its user, and
adds a test that every name SuiteSparse.jl binds exists. Unblocks the
next bump on Julia `master`. The fix for `release-1.14` is #1172.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
ViralBShah added a commit that referenced this pull request Nov 14, 2026
#1169 removed `decrement!` because nothing in this package calls it. But
JuliaSparse/SuiteSparse.jl, which Julia ships as a stdlib, binds `const
decrement! = SparseArrays.decrement!` at load time, so a bump that
includes #1169 fails to build Julia on every platform, as in
JuliaLang/julia#64953:

**Before**
```
ERROR: LoadError: UndefVarError: `decrement!` not defined in `SparseArrays`
  @ .../stdlib/v1.14/SuiteSparse/src/SuiteSparse.jl:9
✗ SuiteSparse
```

**After**: SuiteSparse loads.

This restores the method unchanged, with a comment naming its user, and
adds a test that every name SuiteSparse.jl binds exists. Unblocks the
next bump on Julia `master`. The fix for `release-1.14` is #1172.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit a5441c0)
@ViralBShah ViralBShah closed this Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant