Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/SparseArrays.jl
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@ end
## Functions to switch to 0-based indexing to call external sparse solvers

# Convert from 1-based to 0-based indices
# `decrement!` has no caller here; JuliaSparse/SuiteSparse.jl, which Julia ships as a
# stdlib, binds it at load time.
function decrement!(A::AbstractArray{T}) where T<:Integer
for i in eachindex(A); A[i] -= oneunit(T) end
A
end
decrement(A::AbstractArray) = let y = Array(A)
y .= y .- oneunit(eltype(A))
end
Expand Down
9 changes: 9 additions & 0 deletions test/solvers/issues.jl
Original file line number Diff line number Diff line change
Expand Up @@ -303,4 +303,13 @@ end
@test cond(sparse(Float32[1 2; 3 4]), 1) isa Float32
end

@testset "the names SuiteSparse.jl binds exist" begin
# JuliaSparse/SuiteSparse.jl, which Julia ships as a stdlib, binds these at load time
for name in (:increment, :increment!, :decrement, :decrement!, :LibSuiteSparse,
:CHOLMOD, :SPQR, :UMFPACK)
@test isdefined(SparseArrays, name)
end
@test SparseArrays.decrement!([1, 2, 3]) == [0, 1, 2]
end

end # module
Loading