Custom CoreDNS for GCP and Azure #132
Conversation
aws ttl config remove azure changes from this pr add azure module back
| } | ||
|
|
||
| # Custom CoreDNS Deployment | ||
| resource "kubernetes_deployment" "coredns" { |
There was a problem hiding this comment.
I will move the Coredns ConfigMap, Deployment and Autoscaler to Common Kubernetes Module, since these components are cloud agnostic.
There was a problem hiding this comment.
On a second thought, I am thinking if we should avoid using coredns eks addon in aws as well. That way all the coredns config will be a common kubernetes modules, wdyt @jubrad ?
There was a problem hiding this comment.
Discussed on slack, I agree!
| ] | ||
| } | ||
|
|
||
| # TODO add autoscaler for coredns, should we use cluster-proportional autoscaler or HPA? |
There was a problem hiding this comment.
I looked into this today. coredns/coredns#5915 found a good link that shades some light over using HPA instead of Cluster Proportional Autoscaler.
There was a problem hiding this comment.
discussed on slack, HPA seems like the right call
|
Autoscaler changes are a part of separate PR, meanwhile this PR should be good to review. |
|
Closing this PR, Addressed in #134 |
Uh oh!
There was an error while loading. Please reload this page.