Skip to content

Custom Core dns with HPA for all Cloud Providers#134

Merged
jshiwamV merged 18 commits intomainfrom
core-dns-autoscaler
Jan 6, 2026
Merged

Custom Core dns with HPA for all Cloud Providers#134
jshiwamV merged 18 commits intomainfrom
core-dns-autoscaler

Conversation

@jshiwamV
Copy link
Copy Markdown
Contributor

@jshiwamV jshiwamV commented Dec 22, 2025

@jshiwamV jshiwamV self-assigned this Dec 23, 2025
@jshiwamV jshiwamV marked this pull request as ready for review December 23, 2025 18:21
@jshiwamV jshiwamV changed the title Core dns autoscaler Custom Core dns with HPA for all Cloud Providers Dec 23, 2025
Comment thread gcp/examples/simple/main.tf
Comment thread kubernetes/modules/coredns/main.tf Outdated
Comment thread kubernetes/modules/coredns/main.tf Outdated
Comment thread kubernetes/modules/coredns/main.tf
Comment thread kubernetes/modules/coredns/main.tf Outdated
Comment thread kubernetes/modules/coredns/main.tf Outdated
Comment thread kubernetes/modules/coredns/main.tf Outdated
Comment thread kubernetes/modules/coredns/variables.tf Outdated
Comment thread kubernetes/modules/hpa/variables.tf Outdated
Comment thread kubernetes/modules/coredns/main.tf Outdated
Comment thread aws/examples/simple/main.tf Outdated
module.eks,
module.base_node_group,
module.networking,
module.coredns,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't think Karpenter or any of its EC2NodeClasses or NodePools need coredns, since Karpenter is configured for Default DNS mode, which doesn't use coredns. (Default is to point at the cloud provider's DNS server outside the cluster. The default DNS mode for pods is ClusterFirst, not Default).

This is fine, I won't block the PR for this one. It's just unnecessary.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Default is to point at the cloud provider's DNS server outside the cluster. The default DNS mode for pods is ClusterFirst, not Default).

how about the daemonsets that would run on karpenter nodes, those would rely on Coredns isn't it? Since Pod DNS mode is ClusterFirst. So it makes sense to bring up coredns before provisioning karpenter nodes?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you're right. Karpenter and the node classes don't need it, but the nodepools do.

@jshiwamV jshiwamV added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit de1aef7 Jan 6, 2026
5 checks passed
@jshiwamV jshiwamV deleted the core-dns-autoscaler branch January 6, 2026 12:47
@jshiwamV jshiwamV mentioned this pull request Jan 7, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants