Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution MetaMask internal reviewing guidelines:
|
| }, | ||
| { | ||
| files: ['**/*.test.js', '**/*.test.ts'], | ||
| extends: ['@metamask/eslint-config-jest'], |
There was a problem hiding this comment.
@metamask/eslint-config-vitest needs ESLint 9, I don't think we released a version for ESLint 8. We can enable it again once we bump ESLint.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 68f51f2. Configure here.
mcmire
left a comment
There was a problem hiding this comment.
One comment, but it is non-blocking. LGTM.
| ]); | ||
|
|
||
| vi.mocked(getPackageManifest) | ||
| .mockResolvedValueOnce(getMockManifest(names[0], version) as any) |
There was a problem hiding this comment.
Nit: Should we use // @ts-expect-error instead of as any? (There are some other instances of this further down.)
There was a problem hiding this comment.
Will address in another PR to avoid conflicts in the follow-up PRs I've already created.

Replaces Jest with Vitest, in preparation for switching the package to ESM.
Note
Low Risk
Primarily a test runner/tooling swap; risk is limited to CI/test execution and coverage/typecheck configuration, with no production logic changes.
Overview
Switches the project test stack from Jest to Vitest: removes
jest.config.js, updatespackage.jsonscripts/dependencies, and drops Jest-specific ESLint configuration.Updates all
*.test.tsfiles to use Vitest APIs (vi,describe,it,expect) and Vitest-style ESM mocking/import patterns, and addsvitest.config.tsplustsconfig.test.jsonto enforce coverage and typecheck settings. Also ignores Vitestcoverage/output in.gitignore.Reviewed by Cursor Bugbot for commit 5ca67c6. Bugbot is set up for automated code reviews on this repo. Configure here.