Reject oversized tx_hash lists in construct_block_blob to mitigate DoS#30
Merged
MoneroOcean merged 2 commits intoMay 29, 2026
Conversation
…nstruct_block_blob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tree_hashpath by rejecting overly large merged-mining templates beforeconstruct_parent_blockis invoked.Description
MAX_TX_HASHES_FOR_PARENT_BLOCK = 16384to limit how manytx_hashesare accepted forBLOB_TYPE_FORKNOTE2.b.tx_hashes.size()inconstruct_block_bloband return an error if the template exceeds the limit, avoiding the downstream call chain that leads to stackallocaintree_hash.Testing
npm test, which failed in this environment due to a network/registry403 Forbiddenerror when fetching dependencies (specificallybech32), so automated tests could not complete.Codex Task