Skip to content

Reject oversized tx_hash lists in construct_block_blob to mitigate DoS #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MoneroOcean merged 2 commits into from
May 29, 2026
Merged

Reject oversized tx_hash lists in construct_block_blob to mitigate DoS #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c635847
Guard parent block construction against oversized tx hash lists
MoneroOcean May 29, 2026
085a4a8
Merge branch 'master' into codex/fix-unbounded-stack-allocation-in-co…
MoneroOcean May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ inline void SetExport(Isolate* isolate, Local<Object> target, const char* name,

// cryptonote::append_mm_tag_to_extra writes byte with TX_EXTRA_MERGE_MINING_TAG (1 here) and VARINT DEPTH (2 here)
const size_t MM_NONCE_SIZE = 1 + 2 + sizeof(crypto::hash);
const size_t MAX_TX_HASHES_FOR_PARENT_BLOCK = 16384;
const size_t MAX_BLOCK_ID_TX_HASHES = 65535;

blobdata uint64be_to_blob(uint64_t num) {
Expand Down Expand Up @@ -240,6 +241,7 @@ void construct_block_blob(const FunctionCallbackInfo<Value>& info) { // (parentB

b.nonce = nonce;
if (blob_type == BLOB_TYPE_FORKNOTE2) {
if (b.tx_hashes.size() > MAX_TX_HASHES_FOR_PARENT_BLOCK) return ThrowError(isolate, "Block template has too many transaction hashes.");
block parent_block;
b.parent_block.nonce = nonce;
if (!construct_parent_block(b, parent_block)) return ThrowError(isolate, "Failed to construct parent block");
Expand Down
Loading