PPHA 516: Pilot Give Feedback phase banner#361
Merged
Conversation
stephhou
changed the title
…Digital/lung_cancer_screening into PPHA-516-pilot-give-feedback
Signed-off-by: Steph Housden <167300771+stephhou@users.noreply.github.com>
…Digital/lung_cancer_screening into PPHA-516-pilot-give-feedback
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a GDS/NHS.UK-style “Pilot” phase banner across the site to prompt users for feedback.
Changes:
- Added a new reusable
phase_banner.jinjatemplate for the Pilot phase banner. - Included the phase banner in the global layout header.
- Added Sass styling for the phase banner and updated static-page BDD checks to assert its presence.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lung_cancer_screening/core/jinja2/phase_banner.jinja | New Jinja partial that renders the Pilot phase banner and feedback link |
| lung_cancer_screening/core/jinja2/layout.jinja | Includes the phase banner in the shared layout header |
| lung_cancer_screening/assets/sass/main.scss | Forwards the new phase banner component Sass |
| lung_cancer_screening/assets/sass/components/_phase_banner.scss | Adds custom styling for the phase banner layout |
| features/steps/page_assertion_steps.py | Adds Behave/Playwright steps to assert phase banner content and feedback link |
| features/static.feature | Extends static-page scenarios to check for the phase banner and feedback link |
Comments suppressed due to low confidence (1)
lung_cancer_screening/assets/sass/main.scss:9
main.scssis missing a semicolon after@forward "components/numbered_lists". This will cause Sass compilation to fail because@forwardstatements must be terminated with;(and the new@forwardshould follow the same convention).
@forward 'components/phase_banner';
@forward "components/numbered_lists"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lung_cancer_screening/assets/sass/components/_phase_banner.scss
Outdated
Show resolved
Hide resolved
jamiefalcus
approved these changes
Mar 16, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
Why are we making this change?
To indicate to users that this service is in Pilot phase at the top of the page using a GDS style phase banner.