generated from NHSDigital/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
PPHA 516: Pilot Give Feedback phase banner #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d8399b5
Feat: added phase banner to layout.jinja
stephhou 0ea15ff
test: Added sample tests for phase header
stephhou 8929cd2
Merge branch 'main' into PPHA-516-pilot-give-feedback
stephhou f89b794
fix: Moved phase banner into header for consistency across pages
stephhou 5dc3019
Merge branch 'PPHA-516-pilot-give-feedback' of https://github.com/NHS…
stephhou a84d522
Merge branch 'main' into PPHA-516-pilot-give-feedback
stephhou 404e950
fix: fixed document format
stephhou ddad654
fix: made selections more specific for tests and app
stephhou d8916bd
fix: added lung prefix to css overrides
stephhou 845a47f
Merge branch 'main' into PPHA-516-pilot-give-feedback
stephhou deb293f
Merge branch 'PPHA-516-pilot-give-feedback' of https://github.com/NHS…
stephhou 2f064d0
fix: updated tests to match css selectors
stephhou da1611d
fix: removed unused margin
stephhou 79d503d
Merge branch 'main' into PPHA-516-pilot-give-feedback
stephhou c84d1ec
Merge branch 'main' into PPHA-516-pilot-give-feedback
stephhou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
lung_cancer_screening/assets/sass/components/_phase_banner.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| .lung-nhsuk-phase-banner__container{ | ||
| border-bottom: 1px solid var(--nhsuk-grey-3-colour); | ||
| padding-bottom: 10px; | ||
| padding-top: 10px; | ||
| } | ||
|
|
||
| .lung-nhsuk-phase-banner__content { | ||
| display: table; | ||
| margin: 0; | ||
| } | ||
|
|
||
| .lung-nhsuk-phase-banner__text { | ||
| display: table-cell; | ||
| vertical-align: middle; | ||
| padding-left: 10px; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <section role="region" aria-label="Service phase" class="nhsuk-width-container"> | ||
| <div class="lung-nhsuk-phase-banner__container"> | ||
| <div class="nhsuk-phase-banner"> | ||
| <p class="lung-nhsuk-phase-banner__content"> | ||
| <span class="nhsuk-tag nhsuk-tag__content nhsuk-tag--blue">Pilot</span> | ||
| <span class="lung-nhsuk-phase-banner__text nhsuk-body-s"> | ||
| We are testing a new service – your <a | ||
| href="https://feedback.digital.nhs.uk/jfe/form/SV_6V8dAlFT0sxJnzo" target="_blank" | ||
| rel="noopener">feedback</a> will help us improve it.</span> | ||
| </p> | ||
| </div> | ||
| </div> | ||
| </section> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.