Added de-duping to ailment type calculation to fix double counting bleed and poison.#1819
Open
Andrew-Klotz wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Added de-duping to ailment type calculation to fix double counting bleed and poison.#1819Andrew-Klotz wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Andrew-Klotz wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
…bleed and poison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug with no outstanding issue.
Description of the problem being solved:
Increases/more damage taken on enemies is double counted for physical/chaos ailments (bleed and poison). E.g., Nearby enemies take 10% increased chaos damage results in a 20% increase in the calculations.
Steps taken to verify a working solution:
Confirmed physical/chaos work properly for bleed/poison respectively, while elemental still works for ignite.
Link to a build that showcases this PR:
https://pobb.in/UCOPSE85Cyoz
Before screenshot:
After screenshot: