Skip to content

Added de-duping to ailment type calculation to fix double counting bleed and poison. #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andrew-Klotz wants to merge 1 commit into
base: dev
Choose a base branch
from
+2 −2
Open

Added de-duping to ailment type calculation to fix double counting bleed and poison. #1819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Modules/CalcOffence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4838,8 +4838,8 @@ function calcs.offence(env, actor, activeSkill)
end
else
local resist = calcResistForType(ailmentDamageType, dotCfg)
local takenInc = enemyDB:Sum("INC", dotCfg, "DamageTaken", "DamageTakenOverTime", ailmentDamageType .. "DamageTaken", ailmentDamageType .. "DamageTakenOverTime", ailmentTypeMod .. "DamageTaken")
local takenMore = enemyDB:More(dotCfg, "DamageTaken", "DamageTakenOverTime", ailmentDamageType .. "DamageTaken", ailmentDamageType .. "DamageTakenOverTime", ailmentTypeMod .. "DamageTaken")
local takenInc = enemyDB:Sum("INC", dotCfg, "DamageTaken", "DamageTakenOverTime", ailmentDamageType .. "DamageTaken", ailmentDamageType .. "DamageTakenOverTime") + (ailmentDamageType ~= ailmentTypeMod and enemyDB:Sum("INC", dotCfg, ailmentTypeMod .. "DamageTaken") or 0)
local takenMore = enemyDB:More(dotCfg, "DamageTaken", "DamageTakenOverTime", ailmentDamageType .. "DamageTaken", ailmentDamageType .. "DamageTakenOverTime") * (ailmentDamageType ~= ailmentTypeMod and enemyDB:More("INC", dotCfg, ailmentTypeMod .. "DamageTaken") or 1)
effMult = (1 - resist / 100) * (1 + takenInc / 100) * takenMore
globalOutput[ailment .. "EffMult"] = effMult
if breakdown and effMult ~= 1 then
Expand Down