Add a bunch of type hints - #2454
Merged
LocalIdentity merged 2 commits intoAug 29, 2026
Merged
Conversation
vaisest
force-pushed
the
bunch-of-type-hints
branch
from
August 29, 2026 11:37
33081cb to
d264f6e
Compare
vaisest
force-pushed
the
bunch-of-type-hints
branch
from
August 29, 2026 14:24
d264f6e to
907fab4
Compare
Add the missing AnchorPoint enum and generic Prop<T> type definitions. Allow control anchors to use a Control, ControlHost, or no parent. Pass nil when creating CalcSectionControl without a parent control. Mark optional UI fields such as label, slotLabel, and forceTooltip correctly. Mark optional callbacks and conversion functions correctly. Correct passive tree types, including integer node IDs, optional background data, and nullable node comparisons. Mark main-hand and off-hand calculation outputs as optional. Restrict CalcEnvMode to the modes actually accepted by initEnv. Correct the calculator callback name from toggleTincture to toggleCharm. Mark optional calculator callback arguments correctly. Remove unused or invalid declarations such as byTitle, TransformFunc, points, and Doubled.
LocalIdentity
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
PathOfBuildingCommunity/PathOfBuilding#10227
Based on #2453
Steps taken to verify a working solution: