Fix calculation error with theoretical maximum poison stacks#9595
Draft
majochem wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Draft
Fix calculation error with theoretical maximum poison stacks#9595majochem wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
majochem wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
My previous calculation of the theoretical maximum poison stacks used a value for
singleHitPoisonStacksthat also took into account hit chance and poison chance. However, that incorrectly assumed that a fraction of theadditionalPoisonStackscould be applied, leading to higher theoretical maximums.As a result, lowering your hit chance or poison chance could lead to higher actual poison DPS which is obviously not true. (except the edge cases when lowering hit/poison chance puts you below the threshold for "non-Poisoned Enemy")
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Test Build
(see config mods for easy reproduction of wrong value in current version)
Before screenshot:
95% poison chance leads to 13.44 poison stacks
After screenshot:
Poison stacks correctly limited to 12