Skip to content

Fix calculation error with theoretical maximum poison stacks #9595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
majochem wants to merge 1 commit into
base: dev
Choose a base branch
from
+2 −6
Draft

Fix calculation error with theoretical maximum poison stacks #9595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/Modules/CalcOffence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4430,13 +4430,9 @@ function calcs.offence(env, actor, activeSkill)

-- If stack limit exists, avg. poison stack is more complicated
if poisonStackLimit and poisonStackLimit > 0 and PoisonStacks > poisonStackLimit then
-- Calc number of avg. poisons applied per hit (without hit rate multipliers)
local singleHitPoisonChance = output.HitChance / 100 * poisonChance
local singleHitPoisonStacks = singleHitPoisonChance * additionalPoisonStacks

-- Calc how many hits will poison before limit is reached and theoretical max poison stacks, which is different from `poisonStackLimit` due to "additional" poison mechanics
local numPoisoningHits = m_ceil(poisonStackLimit / singleHitPoisonStacks)
local maxPoisonStacks = numPoisoningHits * singleHitPoisonStacks
local numPoisoningHits = m_ceil(poisonStackLimit / additionalPoisonStacks)
local maxPoisonStacks = numPoisoningHits * additionalPoisonStacks

-- Only use `maxPoisonStacks` if original value exceeds it
uncappedPoisonStacks = m_max(PoisonStacks, maxPoisonStacks)
Expand Down
Loading