-
-
Notifications
You must be signed in to change notification settings - Fork 798
Add solution for Challenge 19 by azs0309 #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azs0309
wants to merge
2
commits into
RezaSi:main
Choose a base branch
from
azs0309:challenge-19-azs0309-1766168121
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "fmt" | ||
| ) | ||
|
|
||
| func main() { | ||
| // Example slice for testing | ||
| numbers := []int{3, 1, 4, 1, 5, 9, 2, 6} | ||
|
|
||
| // Test FindMax | ||
| max := FindMax(numbers) | ||
| fmt.Printf("Maximum value: %d\n", max) | ||
|
|
||
| // Test RemoveDuplicates | ||
| unique := RemoveDuplicates(numbers) | ||
| fmt.Printf("After removing duplicates: %v\n", unique) | ||
|
|
||
| // Test ReverseSlice | ||
| reversed := ReverseSlice(numbers) | ||
| fmt.Printf("Reversed: %v\n", reversed) | ||
|
|
||
| // Test FilterEven | ||
| evenOnly := FilterEven(numbers) | ||
| fmt.Printf("Even numbers only: %v\n", evenOnly) | ||
| } | ||
|
|
||
| // FindMax returns the maximum value in a slice of integers. | ||
| // If the slice is empty, it returns 0. | ||
| func FindMax(numbers []int) int { | ||
| if len(numbers) == 0{ | ||
| return 0 | ||
| } | ||
| max := numbers[0] | ||
| for _ , number := range numbers[1:] { | ||
| if max < number{ | ||
| max = number | ||
| } | ||
| } | ||
|
|
||
| return max | ||
| } | ||
|
|
||
| // RemoveDuplicates returns a new slice with duplicate values removed, | ||
| // preserving the original order of elements. | ||
| func RemoveDuplicates(numbers []int) []int { | ||
| if len(numbers) == 0{ | ||
| return []int{} | ||
| } | ||
| result := make([]int,0,len(numbers)) | ||
|
|
||
| result = append(result, numbers[0]) | ||
| for _, number := range numbers { | ||
| found := false | ||
| for _, inresult := range result { | ||
| if number == inresult { | ||
| found = true | ||
| } | ||
| } | ||
| if !found { | ||
| result = append(result, number) | ||
| } | ||
| } | ||
| return result | ||
| } | ||
|
|
||
| // ReverseSlice returns a new slice with elements in reverse order. | ||
| func ReverseSlice(slice []int) []int { | ||
| if len(slice) == 0{ | ||
| return []int{} | ||
| } | ||
| // if len(slice) == 1{ | ||
| // return slice | ||
| // } | ||
| reversed := make([]int,0,len(slice)) | ||
| for i := len(slice)-1; i >= 0 ; i-- { | ||
| reversed = append(reversed,slice[i]) | ||
| } | ||
| return reversed | ||
| } | ||
|
|
||
| // FilterEven returns a new slice containing only the even numbers | ||
| // from the original slice. | ||
| func FilterEven(numbers []int) []int { | ||
| if len(numbers) == 0{ | ||
| return []int{} | ||
| } | ||
| filtered := make([]int,0) | ||
| for _, number := range numbers { | ||
| if number%2 == 0 { | ||
| filtered = append(filtered, number) | ||
| } | ||
| } | ||
| return filtered | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Remove commented-out code.
The commented lines are unnecessary dead code and should be removed to keep the codebase clean.
🔎 Proposed fix
if len(slice) == 0{ return []int{} } -// if len(slice) == 1{ -// return slice -// } reversed := make([]int,0,len(slice))📝 Committable suggestion
🤖 Prompt for AI Agents