Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep mode requests like "change it to dark" in theme refinements
Acceptance Criteria fulfillment
Fixes #1433
inferModeandrequestedRefinementFieldsnow share oneMODE_REQUESTpattern (switch|change|set|turn (it) to light|dark). Before this change, the field check only knew "switch to light/dark", solimitRefinementSuggestiondropped themodethat both the provider and the local parsing had found.Video/Screenshots
No visual change outside the theme assistant, and reproducing the bug in the UI needs an AI provider, so the new unit test covers it:
Without the fix, the new test fails:
PR Test Details
node --test src/lib/generateThemeFromColor.test.jsinpackages/layout_editor: 18 tests, 0 failures. This is the package's only test file, the same oneyarn testruns.eslint --max-warnings 0on both changed files: no problems.