Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/layout_editor/src/lib/generateThemeFromColor.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,22 @@ test('an explicit light or dark mode refinement overrides an adapter response',
);
});

test('mode refinements without the word mode or theme are kept', () => {
[
['Switch it to dark', 'dark'],
['Change it to dark', 'dark'],
['Set it to dark', 'dark'],
['Turn it to light', 'light'],
['Change to light', 'light'],
].forEach(([request, mode]) => {
assert.deepEqual(
limitRefinementSuggestion({ primaryHex: '#ef4444' }, request),
{ mode },
request
);
});
});

test('explicit corner and font refinements override an adapter response', () => {
assert.deepEqual(
limitRefinementSuggestion(
Expand Down
9 changes: 5 additions & 4 deletions packages/layout_editor/src/lib/themeGenerationService.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,12 @@ const inferFontFamily = (description) => {
return undefined;
};

// "switch to dark", "change it to light", "set it to dark", ...
const MODE_REQUEST = /\b(?:switch|change|set|turn)\s+(?:it\s+)?to\s+(light|dark)\b/;

const inferMode = (description) => {
const prompt = description.toLowerCase();
const requestedMode = prompt.match(
/\b(?:switch|change|set|turn)\s+(?:it\s+)?to\s+(light|dark)\b/
);
const requestedMode = prompt.match(MODE_REQUEST);
if (requestedMode) return requestedMode[1];

const namedThemeMode = prompt.match(/\b(light|dark)\s+(?:mode|theme)\b/);
Expand Down Expand Up @@ -125,7 +126,7 @@ const requestedRefinementFields = (description) => {
inferFontFamily(description) ||
/\b(font|typeface|typography)\b/.test(prompt)
) fields.add('fontFamily');
if (/\b(dark|light)\s+(mode|theme)\b|\bswitch\s+to\s+(dark|light)\b/.test(prompt)) {
if (/\b(dark|light)\s+(mode|theme)\b/.test(prompt) || MODE_REQUEST.test(prompt)) {
fields.add('mode');
}
if (/\b(message view|message type|bubble|flat)\b/.test(prompt)) {
Expand Down