aes: remove references to old aes_backend cfgs - #597
Merged
Merged
Conversation
tarcieri
reviewed
Sep 18, 2026
Comment on lines
+111
to
+146
| @@ -143,7 +143,7 @@ jobs: | |||
| include: | |||
| - target: x86_64-unknown-linux-gnu | |||
| rust: stable | |||
| RUSTFLAGS: '-Dwarnings --cfg aes_backend="avx512"' | |||
| RUSTFLAGS: "-Dwarnings" | |||
Member
There was a problem hiding this comment.
Without aes_backend these two CI configs duplicate each other, so one can be removed.
TechnoPorg
force-pushed
the
push-ppmsuyxuokrq
branch
from
September 18, 2026 11:58
a98f550 to
613d52d
Compare
newpavlov
reviewed
Sep 18, 2026
Member
There was a problem hiding this comment.
It would be nice to have two separate SDE configurations: with and without AVX-512 to test both vaes256 and vaes512 backends.
Contributor
Author
There was a problem hiding this comment.
I've made them use Alder Lake (for vaes256) and Granite Rapids (for vaes512) respectively. If you'd prefer to keep it using -future instead of pinning to a specific microarchitecture that works too
TechnoPorg
force-pushed
the
push-ppmsuyxuokrq
branch
from
September 19, 2026 12:35
613d52d to
dc61980
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #596
cc @tarcieri