Skip to content

aes: remove references to old aes_backend cfgs #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newpavlov merged 1 commit into from
Sep 19, 2026
Merged

aes: remove references to old aes_backend cfgs #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .github/workflows/aes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ jobs:
include:
- target: x86_64-unknown-linux-gnu
rust: stable
RUSTFLAGS: '-Dwarnings --cfg aes_backend="avx256"'
env:
CARGO_INCREMENTAL: 0
RUSTFLAGS: ${{ matrix.RUSTFLAGS }}
Expand All @@ -122,14 +121,14 @@ jobs:
toolchain: ${{ matrix.rust }}
targets: ${{ matrix.target }}
# NOTE: Write a `.cargo/config.toml` to configure the target for VAES
# NOTE: We use intel-sde as the runner since not all GitHub CI hosts support AVX512
# NOTE: We use intel-sde (emulating Alder Lake) as the runner since not all GitHub CI hosts support AVX256
- name: write .cargo/config.toml
shell: bash
run: |
cd ../aes/..
mkdir -p .cargo
echo '[target.${{ matrix.target }}]' > .cargo/config.toml
echo 'runner = "sde64 -future --"' >> .cargo/config.toml
echo 'runner = "sde64 -adl --"' >> .cargo/config.toml
- run: ${{ matrix.deps }}
- run: cargo test --target ${{ matrix.target }}
- run: cargo test --target ${{ matrix.target }} --features hazmat
Expand All @@ -143,7 +142,6 @@ jobs:
include:
- target: x86_64-unknown-linux-gnu
rust: stable
RUSTFLAGS: '-Dwarnings --cfg aes_backend="avx512"'
env:
CARGO_INCREMENTAL: 0
RUSTFLAGS: ${{ matrix.RUSTFLAGS }}
Expand All @@ -156,14 +154,14 @@ jobs:
toolchain: ${{ matrix.rust }}
targets: ${{ matrix.target }}
# NOTE: Write a `.cargo/config.toml` to configure the target for VAES
# NOTE: We use intel-sde as the runner since not all GitHub CI hosts support AVX512
# NOTE: We use intel-sde (emulating Granite Rapids) as the runner since not all GitHub CI hosts support AVX512
- name: write .cargo/config.toml
shell: bash
run: |
cd ../aes/..
mkdir -p .cargo
echo '[target.${{ matrix.target }}]' > .cargo/config.toml
echo 'runner = "sde64 -future --"' >> .cargo/config.toml
echo 'runner = "sde64 -gnr --"' >> .cargo/config.toml
- run: ${{ matrix.deps }}
- run: cargo test --target ${{ matrix.target }}
- run: cargo test --target ${{ matrix.target }} --features hazmat
Expand Down
5 changes: 0 additions & 5 deletions aes/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@
//! used or passing `RUSTFLAGS=-Ctarget-feature=+aes,+avx512f,+ssse3,+vaes`
//! will ensure that AESNI and VAES are always used.
//!
//! Note: Enabling VAES256 or VAES512 still requires specifying `--cfg
//! aes_backend = "avx256"` or `--cfg aes_backend = "avx512"` explicitly.
//!
//! Programs built in this manner will crash with an illegal instruction on
//! CPUs which do not have AES-NI and VAES enabled.
//!
Expand Down Expand Up @@ -104,8 +101,6 @@
//!
//! - `aes_backend`: explicitly select one of the following backends:
//! - `soft`: force software backend
//! - `avx256`: force AVX2 backend
//! - `avx512`: force AVX-512 backend
//! - `aes_backend_soft`: modify software backend:
//! - `compact`: use compact implementation (less performant, but results in a smaller binary)
//!
Expand Down
Loading