manually flush event buffer when shutting down #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanechternacht
approved these changes
Dec 12, 2025
| # Do a final flush before shutting down to avoid losing buffered events | ||
| await self._flush() | ||
| self.shutdown_event.set() | ||
| await self.flush_task |
Contributor
There was a problem hiding this comment.
do we still need to await this then? I guess it shouldn't hurt -- it no-ops anyway
(the await self.flush_task)
Collaborator
Author
There was a problem hiding this comment.
we do because we want to ensure that the background tasks close before we return.
cbrady
deleted the
chris/sch-5404-python-sdk-asyncclient-doesnt-flush-events-on-shutdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.