Skip to content

manually flush event buffer when shutting down #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbrady merged 1 commit into from
Dec 12, 2025
Merged

manually flush event buffer when shutting down #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/schematic/event_buffer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ def push(self, event: CreateEventRequestBody):
def stop(self):
try:
self.stopped = True
# Do a final flush before shutting down to avoid losing buffered events
self._flush()
self.shutdown.set()
self.flush_thread.join(timeout=5)
except Exception as e:
Expand Down Expand Up @@ -222,6 +224,8 @@ async def push(self, event: CreateEventRequestBody):
async def stop(self):
try:
self.stopped = True
# Do a final flush before shutting down to avoid losing buffered events
await self._flush()
self.shutdown_event.set()
await self.flush_task
Copy link
Contributor

@ryanechternacht ryanechternacht Dec 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need to await this then? I guess it shouldn't hurt -- it no-ops anyway

(the await self.flush_task)

Copy link
Collaborator Author

@cbrady cbrady Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do because we want to ensure that the background tasks close before we return.

except Exception as e:
Expand Down
Loading