[ReactNative] Upgrade to alpha.3 native sdks - adds loglevel / colorscheme changes - #484
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Package Size
React Native file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
4c7c337 to
b8fe149
Compare
31b40ea to
2063598
Compare
2063598 to
f5d8a51
Compare
b8fe149 to
20f1384
Compare
f5d8a51 to
d55527a
Compare
424de14 to
80eb817
Compare
80eb817 to
f6e022b
Compare
| | GenericError | ||
| | InternalError; | ||
|
|
||
| export function parseCheckoutError( |
There was a problem hiding this comment.
unnecessary wrapper now
f6e022b to
b190898
Compare
b190898 to
caaee4a
Compare
caaee4a to
1dc6b16
Compare
|
|
||
| public class ShopifyCheckoutKitModule extends NativeShopifyCheckoutKitSpec { | ||
|
|
||
| /** The JavaScript name for {@link CheckoutAppearance.Storefront}, which has no native id. */ |
There was a problem hiding this comment.
The other keys extend ColorScheme so we use getId() but the storefront is not modeled as such, may be able to rework this in future to remove this manual element
markmur
left a comment
There was a problem hiding this comment.
Looks good. It would nice to have some CheckoutException parsing in the sample app to see how consumers should expect to do this now
| this.code = getCheckoutErrorCode(exception?.code); | ||
| this.message = exception?.message; | ||
| this.name = this.constructor.name; | ||
| this.message = exception?.message ?? ''; |
There was a problem hiding this comment.
We might want a better fallback here
| this.message = exception?.message ?? ''; | |
| this.message = exception?.message ?? 'Unexpected error'; |
or
| this.message = exception?.message ?? ''; | |
| this.message = exception?.message ?? 'Unknown error'; |
Merge activity
|
|
@markmur agree - setting up a pr to add handling of the error and updating readme to be comprehensive on the error codes |
### What changes are you making? `dev rn test ios` had no way to run against the in-repo `platforms/swift` sources, so it always resolved the released pod. Add a `--local` flag, matching `dev rn ios --local`. `--local` sets `USE_LOCAL_SDK=1`, which the integration app `Podfile` already reads, then runs `pod update` on the two Checkout Kit pods instead of `pod install`. `pod install` would reuse the lockfile pin and ignore the local path. ### How to test ``` dev rn test ios --local ``` Stacked on #484. --- 🤖 Generated with [Claude Code](https://claude.com/claude-code)

What changes are you making?
This is just an update PR for React Native library to match the Swift and Android recent changes
Colour scheme verification — React Native alpha.3
I did detect some issues with colors but they appear to predate this sdk over to v3 and I'm following up here: https://app.graphite.com/github/pr/Shopify/checkout-kit/597/fix(react-native)-always-assign-checkout-colors-on-setConfig with a full fix, however testing on this branch shows we are properly mapping the themes over
iOS
Android
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.