test(rn): assert the native Swift error codes match the JavaScript enum - #584
Draft
kieran-osgood-shopify wants to merge 1 commit into
Draft
test(rn): assert the native Swift error codes match the JavaScript enum#584kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood-shopify wants to merge 1 commit into
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 5, 2026
kieran-osgood-shopify
changed the base branch from
kieran-osgood/07-16-featupdatereact-nativetousenewnativecolorschemeproperties
to
graphite-base/584
August 6, 2026 10:01
Replace the hand-written code map with `CheckoutErrorCode.allCases`, and fail when the native SDK declares a code that `src/errors.ts` omits. Blocked: this needs ShopifyCheckoutKit 4.0.0-alpha.4, because `CaseIterable` arrives in that release. The integration app pins alpha.3, so the test only compiles today under `dev rn test ios --local`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
force-pushed
the
graphite-base/584
branch
from
August 6, 2026 18:19
f6e022b to
d48982a
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/rn-swift-error-code-parity-test
branch
from
August 6, 2026 18:19
be865ca to
8531bbb
Compare
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.