Skip to content

[Android][lint] Fix android sample package name - #587

Merged
kiftio merged 1 commit into
mainfrom
08-05-fix_android_sample_package_name
Aug 6, 2026
Merged

[Android][lint] Fix android sample package name#587
kiftio merged 1 commit into
mainfrom
08-05-fix_android_sample_package_name

Conversation

@kiftio

@kiftio kiftio commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

Renames the Android demo app's package from com.shopify.checkout_kit_android_demo to com.shopify.checkoutkit.androiddemo to align with Android package naming conventions (no underscores). This includes updating the namespace in build.gradle, the Apollo GraphQL package name, all Kotlin source file package declarations, and all import statements throughout the app and test sources. The ID data class previously located in com.shopify.checkout_kit_android_demo.common (as ModelMappingExt.kt) is moved to the equivalent location under the new package.

How to test

  1. Open the CheckoutKitAndroidDemo project in Android Studio.
  2. Verify the project syncs and builds without errors.
  3. Run the app on a device or emulator and confirm all screens (home, cart, products, settings, logs) function as expected.
  4. Run the unit tests and confirm they all pass.

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Aug 6, 2026

kiftio commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@kiftio kiftio changed the title fix android sample package name [Android][lint] Fix android sample package name Aug 6, 2026
@kiftio
kiftio marked this pull request as ready for review August 6, 2026 14:54
@kiftio
kiftio requested a review from a team as a code owner August 6, 2026 14:54
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
Android release AAR 273.6 KiB 273.6 KiB 0 B
Android file breakdown
File Base Head Delta
classes.jar 289.5 KiB 289.5 KiB 0 B
res/layout/checkout_view_content.xml 2.3 KiB 2.3 KiB 0 B
res/layout/checkout_sheet_content.xml 2.0 KiB 2.0 KiB 0 B
res/values/values.xml 1.2 KiB 1.2 KiB 0 B
R.txt 1.1 KiB 1.1 KiB 0 B
proguard.txt 798 B 798 B 0 B
AndroidManifest.xml 578 B 578 B 0 B
res/drawable/close.xml 431 B 431 B 0 B
res/menu/checkout_menu.xml 354 B 354 B 0 B
META-INF/com/android/build/gradle/aar-metadata.properties 157 B 157 B 0 B

Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report.

@bitrise

bitrise Bot commented Aug 6, 2026

Copy link
Copy Markdown

Install this build

Open Tophat, select your target device, then click Install. Links open on the Mac running Tophat.

SDK Install
Kotlin Install with Tophat

Checkout Kit E2E results

Status Suite Target Platform OS version tag Device
tests/shared/launch-smoke.yaml kotlin android latest Google Pixel 9
Android 17.0

kiftio commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Aug 6, 3:26 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 6, 3:28 PM UTC: Graphite rebased this pull request as part of a merge.
  • Aug 6, 3:33 PM UTC: @kiftio merged this pull request with Graphite.

@kiftio
kiftio changed the base branch from 08-05-setup_sample_lint_and_formatting to graphite-base/587 August 6, 2026 15:26
@kiftio
kiftio changed the base branch from graphite-base/587 to main August 6, 2026 15:26
@kiftio
kiftio force-pushed the 08-05-fix_android_sample_package_name branch from 777cbec to fa27616 Compare August 6, 2026 15:27
@kiftio
kiftio merged commit 48dc45f into main Aug 6, 2026
32 of 33 checks passed
@kiftio
kiftio deleted the 08-05-fix_android_sample_package_name branch August 6, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants