Skip to content

[Android][lint] Enable function naming lint rule - #588

Open
kiftio wants to merge 1 commit into
mainfrom
08-05-enable_function_naming_lint
Open

[Android][lint] Enable function naming lint rule#588
kiftio wants to merge 1 commit into
mainfrom
08-05-enable_function_naming_lint

Conversation

@kiftio

@kiftio kiftio commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

Extends the Detekt configuration for the Android sample app to enforce FunctionNaming checks in addition to formatting rules. The FunctionNaming rule is enabled with annotations for @Composable and @Test excluded, allowing idiomatic PascalCase Composable names and descriptive backtick-style test function names without triggering violations. CI and dev command descriptions have been updated to reflect that both formatting and linting are now checked for the sample.

How to test

  1. Run ./gradlew -p samples/CheckoutKitAndroidDemo :app:detekt and verify it passes cleanly.
  2. Introduce a non-Composable, non-Test function in the sample with a PascalCase name and confirm Detekt flags it.
  3. Confirm that @Composable and @Test annotated functions with PascalCase or backtick names do not trigger violations.

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Aug 6, 2026
@kiftio kiftio mentioned this pull request Aug 6, 2026
11 tasks

kiftio commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@kiftio kiftio changed the title enable function naming lint [Android][lint] Enable function naming lint rule Aug 6, 2026
@kiftio
kiftio marked this pull request as ready for review August 6, 2026 14:55
@kiftio
kiftio requested a review from a team as a code owner August 6, 2026 14:55
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
Android release AAR 273.6 KiB 273.6 KiB 0 B
Android file breakdown
File Base Head Delta
classes.jar 289.5 KiB 289.5 KiB 0 B
res/layout/checkout_view_content.xml 2.3 KiB 2.3 KiB 0 B
res/layout/checkout_sheet_content.xml 2.0 KiB 2.0 KiB 0 B
res/values/values.xml 1.2 KiB 1.2 KiB 0 B
R.txt 1.1 KiB 1.1 KiB 0 B
proguard.txt 798 B 798 B 0 B
AndroidManifest.xml 578 B 578 B 0 B
res/drawable/close.xml 431 B 431 B 0 B
res/menu/checkout_menu.xml 354 B 354 B 0 B
META-INF/com/android/build/gradle/aar-metadata.properties 157 B 157 B 0 B

Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report.

@bitrise

bitrise Bot commented Aug 6, 2026

Copy link
Copy Markdown

Install this build

Open Tophat, select your target device, then click Install. Links open on the Mac running Tophat.

SDK Install
Kotlin Install with Tophat

Checkout Kit E2E results

Status Suite Target Platform OS version tag Device
tests/shared/launch-smoke.yaml kotlin android latest Google Pixel 9
Android 17.0

@kiftio
kiftio changed the base branch from 08-05-fix_android_sample_package_name to graphite-base/588 August 6, 2026 15:27
@kiftio
kiftio force-pushed the graphite-base/588 branch from 777cbec to 48dc45f Compare August 6, 2026 15:34
@kiftio
kiftio force-pushed the 08-05-enable_function_naming_lint branch from 1862cd4 to 23aa4ec Compare August 6, 2026 15:34
@graphite-app
graphite-app Bot changed the base branch from graphite-base/588 to main August 6, 2026 15:34
@kiftio
kiftio force-pushed the 08-05-enable_function_naming_lint branch from 23aa4ec to de8ea2e Compare August 6, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant