Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/android-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ jobs:
STOREFRONT_DOMAIN: example.myshopify.com
STOREFRONT_ACCESS_TOKEN: test-token

- name: Sample formatting and Android Lint
- name: Sample formatting and linting
run: |
./gradlew lintRelease
./gradlew -p samples/CheckoutKitAndroidDemo :app:detekt :app:lintRelease
2 changes: 1 addition & 1 deletion dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ commands:
/opt/dev/bin/dev android check android-lint
subcommands:
detekt:
desc: Run library static analysis and sample formatting checks
desc: Run library static analysis and sample formatting/linting checks
run: |
scripts/check_storefront_env
platforms/android/gradlew -p platforms/android detekt
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,9 @@ tasks.withType(KotlinJvmCompile).configureEach {
}


// The sample applies only auto-correctable formatting rules. Full Detekt static analysis remains
// enabled for the published library; enabling default rules here would surface unrelated existing
// sample debt rather than make this formatting check actionable.
// The sample applies auto-correctable formatting and function-naming checks. Full Detekt static
// analysis remains enabled for the published library; enabling all default rules here would surface
// unrelated existing sample debt rather than make these checks actionable.
detekt {
buildUponDefaultConfig = false
config.setFrom('../detekt.config.yml')
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# The sample intentionally applies only Detekt formatting rules. Full static analysis is enforced
# for the published library, while this keeps sample lint adoption actionable without a baseline.
# The sample enforces formatting and function naming. Compose UI and JUnit test functions use
# idiomatic PascalCase and descriptive backticked names, respectively. Full static analysis is
# enforced for the published library; enabling all default rules here would surface unrelated debt.
naming:
FunctionNaming:
active: true
ignoreAnnotated: [ 'Composable', 'Test' ]

formatting:
active: true
autoCorrect: true
Expand Down
Loading