add artifact upload for swift test failures - #595
Open
kieran-osgood-shopify wants to merge 1 commit into
Open
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
kieran-osgood-shopify
added a commit
that referenced
this pull request
Aug 6, 2026
Breaks two builds on purpose to prove the artifact upload added in #595 actually attaches a bundle. Delete this branch once CI has been observed. Two deliberate failures: - LockedValueTests.testGetReturnsInitialValue asserts a wrong value, so the Run Package Tests job fails and should attach swift-package-tests-xcresult. - PriceFormatter.swift declares a String constant with an Int literal, so ShopifyAcceleratedCheckoutsApp fails to compile and the Build Sample Apps job should attach swift-sample-builds-xcresult. The sample break targets the second app on purpose. build_samples builds CheckoutKitSwiftDemo first and uses set -euo pipefail, so breaking the second app lets the first one finish. That leaves two scheme-named bundles in .xcresults, which is what proves the names do not collide. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
force-pushed
the
swift-artifact-upload
branch
from
August 6, 2026 13:06
ba95c71 to
a5df829
Compare
kieran-osgood-shopify
added a commit
that referenced
this pull request
Aug 6, 2026
Breaks two builds on purpose to prove the artifact upload added in #595 actually attaches a bundle. Delete this branch once CI has been observed. Two deliberate failures: - LockedValueTests.testGetReturnsInitialValue asserts a wrong value, so the Run Package Tests job fails and should attach swift-package-tests-xcresult. - PriceFormatter.swift declares a String constant with an Int literal, so ShopifyAcceleratedCheckoutsApp fails to compile and the Build Sample Apps job should attach swift-sample-builds-xcresult. The sample break targets the second app on purpose. build_samples builds CheckoutKitSwiftDemo first and uses set -euo pipefail, so breaking the second app lets the first one finish. That leaves two scheme-named bundles in .xcresults, which is what proves the names do not collide. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
marked this pull request as ready for review
August 7, 2026 10:39
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
kieran-osgood-shopify
force-pushed
the
swift-artifact-upload
branch
from
August 7, 2026 14:18
a5df829 to
a288284
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
We use annotations for quick views with inline warnings/failures but they cap out at 10 per workflow, 50 per job, and given swiftlint also posts to them some information may start to get lost as we scale our monorepo
this gives a table of results that can be easier to grok multiple failures in sequence
Exmaple here: https://github.com/Shopify/checkout-kit/actions/runs/31108425595?pr=596
How to test
See failing branch here: https://github.com/Shopify/checkout-kit/actions/runs/31108425595?pr=596
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.