DO NOT MERGE: verify xcresult capture in CI - #596
Closed
Conversation
11 tasks
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kieran-osgood-shopify
marked this pull request as ready for review
August 6, 2026 12:53
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
kieran-osgood-shopify
force-pushed
the
swift-artifact-upload
branch
from
August 6, 2026 13:06
ba95c71 to
a5df829
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift-artifact-upload/verify-xcresult-capture
branch
from
August 6, 2026 13:06
8eef2b7 to
198d566
Compare
Breaks two builds on purpose to prove the artifact upload added in #595 actually attaches a bundle. Delete this branch once CI has been observed. Two deliberate failures: - LockedValueTests.testGetReturnsInitialValue asserts a wrong value, so the Run Package Tests job fails and should attach swift-package-tests-xcresult. - PriceFormatter.swift declares a String constant with an Int literal, so ShopifyAcceleratedCheckoutsApp fails to compile and the Build Sample Apps job should attach swift-sample-builds-xcresult. The sample break targets the second app on purpose. build_samples builds CheckoutKitSwiftDemo first and uses set -euo pipefail, so breaking the second app lets the first one finish. That leaves two scheme-named bundles in .xcresults, which is what proves the names do not collide. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
changed the base branch from
swift-artifact-upload
to
graphite-base/596
August 6, 2026 13:57
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift-artifact-upload/verify-xcresult-capture
branch
from
August 6, 2026 13:57
198d566 to
3d95e31
Compare
kieran-osgood-shopify
changed the base branch from
graphite-base/596
to
kieran-osgood/swift-artifact-upload/xcresult-step-summary
August 6, 2026 13:57
kieran-osgood-shopify
deleted the
kieran-osgood/swift-artifact-upload/verify-xcresult-capture
branch
August 7, 2026 14:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
DO NOT MERGE. This branch breaks two builds on purpose. Delete it once CI has been observed.
Stack Context
Stacked on #595, which adds
-resultBundlePathtoxcode_runand anif: failure()artifact upload to the shared Swift workflow.Everything in #595 was verified locally except the upload step itself, which needs a real GitHub run. This branch forces that run.
What?
Two deliberate failures:
LockedValueTests.testGetReturnsInitialValueasserts a wrong valueswift-package-tests-xcresultPriceFormatter.swiftdeclares aStringconstant with anIntliteralswift-sample-builds-xcresultWhy break the second sample app?
build_samplesbuildsCheckoutKitSwiftDemofirst, thenShopifyAcceleratedCheckoutsApp, underset -euo pipefail.Breaking the second app lets the first one finish. Two scheme-named bundles therefore land in
.xcresults/, which is the only way to prove the bundle names do not collide. Breaking the first app would write just one bundle and prove nothing about naming.Pass criteria
swift-package-tests-xcresultswift-sample-builds-xcresult.xcresultbundles, one per scheme🤖 Generated with Claude Code