Repository navigation
Add GitHub link beside the app version - #83
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a GitHub link to the right of the version and commit on the home screen, matching BrowserMegaProxy's footer. It opens the AndroidMegaProxy repository through Android's standard link handler, wraps on narrow screens, and shows the existing localized error if no browser can handle the link.
Validation:
bundle exec fastlane android android_checkspassed — 276 JVM tests, lint, debug build and unsigned release build. The added UI test verifies that tapping GitHub opens the correct repository without issuing a VPN service command.APK artifacts
Built from commit
c107dabbby CI run #297.Artifacts expire after 14 days. Neither APK uses the MegaProxy release key.