Fix the LICENSE and NOTICE files for the binary distribution, including transitive dependencies#2703
Conversation
| @@ -0,0 +1,1173 @@ | |||
| Apache License | |||
There was a problem hiding this comment.
Just curious — are these LICENSE files in the binary distribution auto-generated or manually maintained? And when Fluss adds new dependencies in the future, do we need to manually include their licenses as well?
There was a problem hiding this comment.
Also, I'm not entirely clear on the distinction between NOTICE and LICENSE — when should something go into the NOTICE file vs. the LICENSE file? Would appreciate some guidance on this so I can better understand the process. 🙏
There was a problem hiding this comment.
It's pretty hard to have all auto-generated (especially when you shade a dependency which has itself a shade dependency). I'm having some scripts to assist me, but I do most the checks "manually".
The LICENSE should contain all code and dependencies you bundle in the artifact, with the type of license and copyright. In the case of BSD or MIT license, the license content should be inline our own LICENSE.
The NOTICE file should be as simple as possible. It should contain only the relevant information of the NOTICE file for the Apache license dependencies. For instance, Netty is Apache licensed dependency, so as Netty has a NOTICE, the Netty NOTICE content should be in our NOTICE (the relevant information).
If the Apache licensed dependency doesn't have NOTICE, nothing is required.
In the case of ASF dependencies (like Apache Flink), it's not strictly required to include NOTICE because it's covered by This product includes software developed at The Apache Software Foundation (http://www.apache.org/).
There was a problem hiding this comment.
Thanks JB, that's a really thorough and expert explanation! Super helpful, really clears things up for me. 🙏
|
|
||
| ------------------------------------------------------------------------------------ | ||
|
|
||
| This product bundles Apache Hive. |
There was a problem hiding this comment.
I'm curious, where does it bundle Hive? Which module or dependency pulls it in?
There was a problem hiding this comment.
Hive is shaded in the paimon bundle (in plugins/paimon).
…ng transitive dependencies.
3390960 to
19e5404
Compare
…n, including transitive dependencies. (apache#2703)
This PR fixes the
LICENSEandNOTICEfiles for the binary distribution with: