Skip to content

Comments

Fix the LICENSE and NOTICE files for the binary distribution, including transitive dependencies#2703

Merged
luoyuxia merged 1 commit intoapache:mainfrom
jbonofre:license-notice-improvements
Feb 21, 2026
Merged

Fix the LICENSE and NOTICE files for the binary distribution, including transitive dependencies#2703
luoyuxia merged 1 commit intoapache:mainfrom
jbonofre:license-notice-improvements

Conversation

@jbonofre
Copy link
Member

This PR fixes the LICENSE and NOTICE files for the binary distribution with:

  • clearly stating all bundles dependencies/code, including the transitive, shaped in the Fluss artifacts (server and plugins)
  • include BSD/MIT license content in line
  • update the NOTICE file correctly

Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbonofre Thanks for the pr. Left some question.
@wuchong Could you please also help review this

@@ -0,0 +1,1173 @@
Apache License
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious — are these LICENSE files in the binary distribution auto-generated or manually maintained? And when Fluss adds new dependencies in the future, do we need to manually include their licenses as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'm not entirely clear on the distinction between NOTICE and LICENSE — when should something go into the NOTICE file vs. the LICENSE file? Would appreciate some guidance on this so I can better understand the process. 🙏

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pretty hard to have all auto-generated (especially when you shade a dependency which has itself a shade dependency). I'm having some scripts to assist me, but I do most the checks "manually".

The LICENSE should contain all code and dependencies you bundle in the artifact, with the type of license and copyright. In the case of BSD or MIT license, the license content should be inline our own LICENSE.

The NOTICE file should be as simple as possible. It should contain only the relevant information of the NOTICE file for the Apache license dependencies. For instance, Netty is Apache licensed dependency, so as Netty has a NOTICE, the Netty NOTICE content should be in our NOTICE (the relevant information).
If the Apache licensed dependency doesn't have NOTICE, nothing is required.

In the case of ASF dependencies (like Apache Flink), it's not strictly required to include NOTICE because it's covered by This product includes software developed at The Apache Software Foundation (http://www.apache.org/).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks JB, that's a really thorough and expert explanation! Super helpful, really clears things up for me. 🙏


------------------------------------------------------------------------------------

This product bundles Apache Hive.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, where does it bundle Hive? Which module or dependency pulls it in?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hive is shaded in the paimon bundle (in plugins/paimon).

@jbonofre jbonofre force-pushed the license-notice-improvements branch from 3390960 to 19e5404 Compare February 21, 2026 13:38
Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbonofre Thank for the pr. LGTM. Merging....

@luoyuxia luoyuxia merged commit f9cd71d into apache:main Feb 21, 2026
7 checks passed
luoyuxia pushed a commit to luoyuxia/fluss that referenced this pull request Feb 21, 2026
@jbonofre jbonofre deleted the license-notice-improvements branch February 22, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants