Repository navigation
fix(store): complete RPC and scan lifecycle - #3303
Merged
imbajin merged 11 commits intoOct 10, 2026
Merged
Conversation
- align client cancellation and server half-close behavior - publish final batches outside response parsing locks - drain RPC callbacks and scan owners before storage close - retain TTL cleanup failures and finish interrupted Raft joins - preserve executable packaging and lifecycle CI coverage
- retain parser failures across completion races - drain heartbeat producers despite interruption - restore interrupts after native database teardown - cover real native close in an isolated subprocess
- keep client and server request lifecycle changes together - retain scoped scan and query cleanup before database close - partition lifecycle tests without changing their assertions - defer global RPC and TTL shutdown to a dependent PR
imbajin
changed the title
This was referenced Oct 9, 2026
- close global RPC admission before request cleanup waits - retain batch half-close credit and explicit client cancellation - track unary query and parallel count resource owners - preserve failed native cleanup independently of RPC completion - keep matching regressions in the RPC prerequisite
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3303 +/- ##
============================================
+ Coverage 41.42% 41.71% +0.28%
- Complexity 6931 7004 +73
============================================
Files 762 762
Lines 66773 66838 +65
Branches 8939 8956 +17
============================================
+ Hits 27662 27880 +218
+ Misses 35957 35770 -187
- Partials 3154 3188 +34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- retain off-thread dispatch during executor saturation - verify cancellation and drain through real Netty RPCs - document callback queue and shutdown boundaries
16 of 69 tasks
- interrupt active readers before iterator cleanup waits - verify context cancellation and deadline cleanup - propagate half-close worker failures into assertions
This was referenced Oct 9, 2026
imbajin
changed the title
- listen to context cancellation during blocked unary work - remove listeners while retaining iterator cleanup accounting - verify query and count cancellation through real Netty RPCs
- interrupt owned batch readers before iterator locks - keep closed partition iterators terminal - refresh the timeout when accepting a response - cover blocked shutdown and parsing boundaries
- combine RPC, recovery and provider guidance - preserve WAL and native ownership safety contracts - remove PR-stage notes and repeated explanations - update entry points to the canonical guide
- recheck the queue after an empty timed poll - preserve producer publication before completion - cover final-batch delivery at the poll boundary
Interrupt active one-shot callers and preserve thread reuse. Close expired streams outside the admission monitor. Report aggregate shutdown cancellation as unavailable. Cover cancellation, terminal delivery and retained cleanup.
MrJs133
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scan completion rechecks producer completion and the queue after an empty timed poll. Cancellation signals the currently owned reader, including one-shot callers, without leaking its interrupt into a subsequent scan. Native reads still retain ownership until they return. Expired batch-stream cleanup runs outside the admission monitor. Aggregate shutdown reports UNAVAILABLE instead of successful partial results.
Global admission and terminal callbacks drain before native shutdown. The existing gRPC executor uses an unbounded callback queue to avoid dropping terminal callbacks; core/max and backlog tradeoffs are documented. Deterministic race, half-close, thread-reuse, Netty cancellation and cleanup regressions passed focused local validation and independent review; backend integration results are reported by the PR checks. Scan benchmarking and full process recovery remain outside the current evidence.
Long-term RPC, recovery, runtime upgrade and provider contracts are consolidated in
docs/storage-lifecycle.md. Merge this prerequisite before the incremental Native shutdown PR.Paired website documentation: hugegraph/hugegraph-doc#39 and apache/hugegraph-doc#513. Coordinate configuration documentation and code merges.