[TIRx] Improve BufferStore cast warning context#20038
Open
tlopex wants to merge 1 commit into
Open
Conversation
Member
Author
|
cc @LeiWang1999 |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the BufferStore function in src/tirx/script/builder/ir.cc to enhance the warning log for precision loss during casting. It now retrieves the kernel name from the current PrimFuncFrame and appends both the kernel name and the BufferStore object to the warning message. There are no review comments, so no additional feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the precision-loss warning emitted while building a
BufferStore.Before this change, the warning only displayed the LHS and RHS dtypes, making it difficult to identify the failing kernel when many kernels were built together:
After this change, the warning also displays the current kernel name and the complete
BufferStorenode: