Skip to content

[TIRx] Improve BufferStore cast warning context #20038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spectrometerHBH merged 1 commit into from
Jul 22, 2026
+12 −3
Merged

[TIRx] Improve BufferStore cast warning context #20038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/tirx/script/builder/ir.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,18 +784,27 @@ void BufferStore(Buffer buffer, PrimExpr value, ffi::Array<PrimExpr> indices,
<< ": LHS is `" << lhs_dtype << "`, RHS is `" << rhs_dtype
<< "`, indexing lanes: " << index_lanes;
}
value = tvm::cast(lhs_dtype, value);
}
tvm::tirx::BufferStore store(buffer, value, indices, predicate);
if (lhs_dtype != rhs_dtype) {
if (lhs_dtype.code() != rhs_dtype.code()) {
if ((lhs_dtype.MatchesCode(DLDataTypeCode::kDLInt, DLDataTypeCode::kDLUInt)) &&
(rhs_dtype.code() == DLDataTypeCode::kDLFloat ||
rhs_dtype.code() == DLDataTypeCode::kDLBfloat)) {
ffi::String kernel_name = "<unknown>";
if (ffi::Optional<PrimFuncFrame> frame = IRBuilder::Current()->FindFrame<PrimFuncFrame>()) {
kernel_name = frame.value()->name.value_or("<anonymous>");
}
LOG(WARNING) << "Casting in BufferStore may lose precision"
<< ": LHS is `" << lhs_dtype << "`, RHS is `" << rhs_dtype
<< "`, indexing lanes: " << index_lanes;
<< "`, indexing lanes: " << index_lanes << ", kernel: `" << kernel_name << "`"
<< "\nBufferStore:\n"
<< store;
}
}
value = tvm::cast(lhs_dtype, value);
}
AddToParent(tvm::tirx::BufferStore(buffer, value, indices, predicate));
AddToParent(store);
}

DeclBufferFrame DeclBuffer(ffi::Array<PrimExpr> shape, PrimType dtype, ffi::String buffer_name,
Expand Down
Loading