Skip to content

fix(pypi): handle revisions in uv.lock Git sources - #4086

Merged
aignas merged 1 commit into
bazel-contrib:mainfrom
henriquejsza:fix/uv-lock-git-source-filename
Aug 22, 2026
Merged

fix(pypi): handle revisions in uv.lock Git sources#4086
aignas merged 1 commit into
bazel-contrib:mainfrom
henriquejsza:fix/uv-lock-git-source-filename

Conversation

@henriquejsza

Copy link
Copy Markdown
Contributor

Git sources in uv.lock can include a revision in the URL query and
fragment. pip.parse currently includes those components in the derived
filename, which can produce an invalid Bazel repository name.

Derive the filename from only the URL path while preserving the complete
revision-bearing Git URL. Regression coverage verifies the filename is clean
and the fetch URL remains unchanged.

Fixes #4084

Copilot AI lite review requested due to automatic review settings August 21, 2026 09:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@aignas aignas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM

@aignas
aignas added this pull request to the merge queue Aug 22, 2026
Merged via the queue into bazel-contrib:main with commit 984d485 Aug 22, 2026
5 checks passed
This was referenced Aug 22, 2026
rickeylev added a commit that referenced this pull request Aug 22, 2026
Cherry-picks:
- #4044
- #4054
- #4086
- #4083

Extra fixes (PR to main in #4090):
- doc: changelog entries for 2.3.2
- chore: fix version numbers

Work towards #4088

---------

Co-authored-by: Richard Levasseur <richardlev@gmail.com>
Co-authored-by: Kristian Hartikainen <kristian@ekarobotics.com>
Co-authored-by: Henrique <121921605+henriquejsza@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pip.parse with uv_lock fails when lock file contains git sourced package

3 participants