fix(BBButton): only default aria-labelledby when a matching label element renders#55
Merged
Merged
Conversation
…ment renders aria-labelledby was always pointed at a generated "-label" id, but only the stacked layout (and default layout with a label) actually render an element with that id. On circle layout, or default layout without a label, the id never exists in the DOM, so axe flags it as referencing a missing element. Now it falls back to aria-label in those cases instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
aria-labelledby was always pointed at a generated "-label" id, but only the stacked layout (and default layout with a label) actually render an element with that id. On circle layout, or default layout without a label, the id never exists in the DOM, so axe flags it as referencing a missing element. Now it falls back to aria-label in those cases instead.