Skip to content

fix(BBButton): only default aria-labelledby when a matching label element renders #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Arthurk12 merged 1 commit into from
Jul 13, 2026
Merged

fix(BBButton): only default aria-labelledby when a matching label element renders #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/components/Button/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,18 @@ function Button(props: ButtonProps): JSX.Element {
} = {};
const generatedId = useId();
const defaultLabelId = `${id || generatedId}-label`;
// Only default aria-labelledby to defaultLabelId when an element with that id is
// actually rendered (stacked always renders ButtonText; default only when labeled).
// circle never renders a label element, so it must rely on aria-label instead —
// otherwise aria-labelledby would point at a non-existent id.
const hasRenderedLabelElement = layout === LAYOUTS.STACKED
|| (layout === LAYOUTS.DEFAULT && Boolean(label));
accessibilityProps['aria-label'] = ariaLabel || label;
accessibilityProps['aria-labelledby'] = ariaLabelledBy || defaultLabelId;
if (ariaLabelledBy) {
accessibilityProps['aria-labelledby'] = ariaLabelledBy;
} else if (hasRenderedLabelElement) {
accessibilityProps['aria-labelledby'] = defaultLabelId;
}
if (ariaDescribedBy) accessibilityProps['aria-describedby'] = ariaDescribedBy;

const buttonElement = (() => {
Expand Down
Loading