fix: prevent built-in Map calls from resolving to project methods (#1566) - #1790
Merged
Conversation
This was referenced Sep 8, 2026
This was referenced Sep 8, 2026
colbymchenry
added a commit
that referenced
this pull request
Sep 8, 2026
…ed type (#1496) (#1792) Land the six-file fix from upstream PR #1691 by danusha2345 (pr-1691 at 6d0e80d), preserving wasm/native extraction parity and exclusive field-type resolution. Preserve coexistence with the #1566 Map/collection fix merged in #1790, including nested holder.values.get coverage and the unchanged #1566 Unreleased changelog bullet. EXTRACTION_VERSION remains unchanged. Align the existing chained-receiver regression with the fix: a declared service field calls its method, while an anonymous field type does not bind to unrelated same-named project functions. Verified on Linux with Node 22.19.0: - Rebuilt the native kernel and TypeScript/browser distribution. - Both backends change Outbox::send -> Outbox::send into Outbox::send -> Mailer::send, keep Relay::forward -> Mailer::send, and store no self-edges in the issue repro. - Wasm: 224 tests passed; native kernel: 255 tests passed, no skips. - All 10 #1566 resolution cases pass on each backend, plus all four nested-receiver extraction parity cases. Co-authored-by: Colby McHenry <colbymchenry@users.noreply.github.com>
bompus
added a commit
to bompus/codegraph
that referenced
this pull request
Sep 8, 2026
…henry#1566) (colbymchenry#1790)" This reverts commit de5adba.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1566.
Calls such as
values.get()on a localMapandholder.values.get()previously linked to unrelated project methods namedget,set, orhas. These calls now stay unresolved, while a localnew LRUCache()still resolves to that class's methods.WeakMapandWeakSet.Verification on Linux x86_64, Node 22.19.0:
72c1ff13: local Map produced three false edges at confidence 0.7; nested Map produced one at 0.9, in both engines.npx tsc,npm run copy-assets, andnpm run build:kernelpassed.CODEGRAPH_KERNEL=0): 889 tests passed across seven related suites.Re-index after upgrading. Nested property types are not inferred by this change. PR #1691 was evaluated and not used: its
this.<field>.method()work remains separately tracked by #1496/#1691.