test(cli): cover Spring route callers regression (#1442) - #1813
Open
colbymchenry wants to merge 1 commit into
Open
test(cli): cover Spring route callers regression (#1442)#1813colbymchenry wants to merge 1 commit into
colbymchenry wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qualified Spring controller lookups could report no route callers even while
nodeand downstreamimpactshowed the handler and route. The old CLI comparedClass.methodto bare symbol names, then used the first full-text search hit. An uncalledstartFlowExcelCdPreviewcan outrankstartFlowExcelCd, reproducing the two-controller asymmetry in #1442.The runtime fix is already merged in #1801 (
8c9c4761): callers resolve the requested definition through the shared symbol lookup. This PR adds four Spring regression tests using a fresh SQLite index and the built CLI, plus an issue-specific Unreleased note. The tests check both directions of each route/handler edge,node, downstreamimpact, and text/JSON callers for each controller.Verified on Linux x64 with Node 22.19.0:
71d049cd): 3 pass, 1 fails, precisely the second controller's empty callers.8c9c4761) and current main: 4 pass. Both stored route edges,node, andimpactare correct in the failing build too.npm run buildpasses.3193800b), with identical failing-test names. The Spring regression, framework extraction/integration, symbol lookup, and CLI definition-grouping suites all pass (231 tests).Issue #1442 predates v1.6.0 and #1801; the behavioral fix is merged but unreleased. The reproduction matches all reported symptoms, although the reporter's full application source was not provided.