instrumentation, log: add support for otel log collection. by klihub · Pull Request #663 · containers/nri-plugins

klihub · 2026-04-16T07:14:07Z

Note: this PR is stacked on #664.

This patch series:

reworks the internal logging backend using slog, adding support for structured logging
cleans up logging calls to consistently use the f-variants for formatted/non-structured logging
adds support for exporting logs to an opentelemetry compatible collector
adds a test case of otel log collection
updates documentation

fmuyassarov · 2026-04-23T20:53:38Z

Sorry for delay, I will go through it tomorrow.

kad

Let's rebase on top of current main, update deps and then it is lgtm from me.

Copilot

Pull request overview

This PR refactors the internal logging subsystem to use log/slog, adds structured logging support, and introduces OpenTelemetry log exporting (OTLP) with an accompanying e2e test and documentation/CRD updates.

Changes:

Replace the legacy klog-based logging implementation with a slog-based backend and handlers (including an OTEL bridge handler).
Add OpenTelemetry log exporting support under instrumentation (OTLP HTTP/gRPC) and wire it into instrumentation startup.
Add an e2e test scenario + collector manifests for validating OTLP log collection; update docs and CRDs to expose new config fields.

Reviewed changes

Copilot reviewed 32 out of 34 changed files in this pull request and generated 18 comments.

Show a summary per file

File	Description
test/e2e/policies.test-suite/topology-aware/n4c16/test40-otel-logging/otel-collector.yaml.in	Adds an OTEL collector deployment/config for log collection in e2e.
test/e2e/policies.test-suite/topology-aware/n4c16/test40-otel-logging/custom-config.yaml.in	Adds topology-aware test config enabling OTLP log export.
test/e2e/policies.test-suite/topology-aware/n4c16/test40-otel-logging/code.var.sh	Adds an e2e validation script that asserts CreateContainer logs are exported.
pkg/resmgr/cache/cache.go	Switches fatal logging to the formatted variant (`Fatalf`).
pkg/log/stdlog.go	Redirects `log` stdlib output through the new logger and uses `Debugf`.
pkg/log/slog.go	Introduces the new `slog`-backed logger implementation and text formatting handler.
pkg/log/slog-logger.go	Removes the previous slog bridge implementation.
pkg/log/signal.go	Removes the previous signal-based debug toggling implementation.
pkg/log/ratelimit.go	Removes the previous rate-limiting logger implementation.
pkg/log/ratelimit_test.go	Removes tests for the removed rate-limiter.
pkg/log/otel.go	Adds an OTEL handler indirection layer to dynamically attach/detach an OTEL slog handler.
pkg/log/logger.go	Defines the new `Logger` interface, levels, and attributes based on slog.
pkg/log/log.go	Removes the legacy logging backend implementation.
pkg/log/default.go	Updates the default logger initialization and flush behavior.
pkg/log/config.go	Reworks logging config parsing/state and debug toggling.
pkg/instrumentation/tracing/tracing.go	Updates semconv dependency version.
pkg/instrumentation/resource.go	Updates semconv dependency version.
pkg/instrumentation/logging/logging.go	Adds OTLP log exporting (OTEL log SDK + otelslog bridge).
pkg/instrumentation/instrumentation.go	Starts logging export as part of instrumentation startup.
pkg/apis/config/v1alpha1/instrumentation/zz_generated.deepcopy.go	Deep-copies the new `LogExportPeriod` field.
pkg/apis/config/v1alpha1/instrumentation/config.go	Adds new config fields for log exporting and kubebuilder markers.
go.mod	Adds OTEL log/otelslog deps and bumps OTEL + other module versions.
go.sum	Updates checksums for the new/bumped dependencies.
docs/resource-policy/setup.md	Documents debug config changes and OTEL log exporting setup.
deployment/helm/topology-aware/crds/config.nri_topologyawarepolicies.yaml	Exposes new instrumentation log fields in helm CRD schema.
deployment/helm/template/crds/config.nri_templatepolicies.yaml	Exposes new instrumentation log fields in helm CRD schema.
deployment/helm/balloons/crds/config.nri_balloonspolicies.yaml	Exposes new instrumentation log fields in helm CRD schema.
config/crd/bases/config.nri_topologyawarepolicies.yaml	Exposes new instrumentation log fields in base CRD schema.
config/crd/bases/config.nri_templatepolicies.yaml	Exposes new instrumentation log fields in base CRD schema.
config/crd/bases/config.nri_balloonspolicies.yaml	Exposes new instrumentation log fields in base CRD schema.
cmd/plugins/topology-aware/policy/topology-aware-policy.go	Updates a call site to use `Infof` rather than the removed `Info`.
cmd/plugins/topology-aware/main.go	Switches `Fatal` to `Fatalf`.
cmd/plugins/template/main.go	Switches `Fatal` to `Fatalf`.
cmd/plugins/balloons/main.go	Switches `Fatal` to `Fatalf`.

Files not reviewed (1)

pkg/apis/config/v1alpha1/instrumentation/zz_generated.deepcopy.go: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+func (h *Handler) WithAttrs(attrs []Attr) slog.Handler {
+	n := &Handler{
+		source: h.source,
+	}
+
+	if h.group == nil {
+		n.attrs = slices.Clone(h.attrs)
+		n.attrs = append(n.attrs, attrs...)
+	} else {
+		n.group = h.group.Clone()
+		n.group.attrs = slices.Clone(attrs)
+	}
+
+	return n
+}


+func (h *Handler) FormatAttrs(buf *bytes.Buffer, r *slog.Record) {
+	prefix := ""
+	groups := []*group{}
+


Signed-off-by: Ukri Niemimuukko <ukri.niemimuukko@intel.com>

Use log.Infof and log.Fatalf consistently everywhere for formatted logging. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

Rework internal logger implementation using slog, allowing us to eventually move to structured logging. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

Add minimal documentation about Opentelemetry-based log exporting. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

askervin

LGTM

askervin · 2026-06-18T14:23:57Z

Let's swallow this, close #688 (included here), and sometimes later see if we could have an e2e test for this... Thanks @klihub!

kad

LGTM

klihub requested a review from askervin April 16, 2026 07:14

klihub force-pushed the devel/otel/logging branch from a79277f to 9ca5935 Compare April 16, 2026 07:25

This was referenced Apr 16, 2026

build(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp from 1.42.0 to 1.43.0 #660

Closed

build(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp from 1.19.0 to 1.43.0 #659

Closed

klihub force-pushed the devel/otel/logging branch 4 times, most recently from 88d42a4 to 6efc5a8 Compare April 16, 2026 08:12

klihub requested a review from fmuyassarov April 16, 2026 08:13

klihub force-pushed the devel/otel/logging branch 2 times, most recently from 42659c7 to 5d9f1a1 Compare April 16, 2026 11:34

askervin reviewed Apr 17, 2026

View reviewed changes

Comment thread Makefile Outdated

Comment thread pkg/version/version.go

Comment thread pkg/instrumentation/logging/logging.go

klihub force-pushed the devel/otel/logging branch 10 times, most recently from 44bc753 to b164f8a Compare April 22, 2026 12:48

klihub marked this pull request as ready for review April 22, 2026 12:50

klihub force-pushed the devel/otel/logging branch from b164f8a to 4a3cd98 Compare April 23, 2026 16:21

klihub mentioned this pull request Jun 18, 2026

Otel library updates #688

Closed

kad reviewed Jun 18, 2026

View reviewed changes

kad requested a review from Copilot June 18, 2026 10:35

Copilot started reviewing on behalf of kad June 18, 2026 10:35 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

klihub force-pushed the devel/otel/logging branch 2 times, most recently from 109858c to 33159d3 Compare June 18, 2026 12:56

uniemimu and others added 7 commits June 18, 2026 15:59

Otel library updates

9d0b8ac

Signed-off-by: Ukri Niemimuukko <ukri.niemimuukko@intel.com>

all: use log.{Info,Fatal}f consistently everywhere.

c5895ab

Use log.Infof and log.Fatalf consistently everywhere for formatted logging. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

log: rip out old logger and plug in slog-based replacement.

4767bf6

Rework internal logger implementation using slog, allowing us to eventually move to structured logging. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

apis: add configuration for otel log exporting.

5e0ee7d

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

instrumentation: implement log exporting.

0008de3

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

e2e: add minimal otel log collection test.

3997d9f

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

docs: update logging and debugging section.

c69731f

Add minimal documentation about Opentelemetry-based log exporting. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

klihub force-pushed the devel/otel/logging branch from 33159d3 to c69731f Compare June 18, 2026 13:00

askervin approved these changes Jun 18, 2026

View reviewed changes

kad approved these changes Jun 18, 2026

View reviewed changes

kad merged commit 417f237 into containers:main Jun 18, 2026
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

instrumentation, log: add support for otel log collection.#663

instrumentation, log: add support for otel log collection.#663
kad merged 7 commits into
containers:mainfrom
klihub:devel/otel/logging

klihub commented Apr 16, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fmuyassarov commented Apr 23, 2026

Uh oh!

kad left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

askervin left a comment

Uh oh!

askervin commented Jun 18, 2026

Uh oh!

kad left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

klihub commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fmuyassarov commented Apr 23, 2026

Uh oh!

kad left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

askervin left a comment

Choose a reason for hiding this comment

Uh oh!

askervin commented Jun 18, 2026

Uh oh!

kad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

klihub commented Apr 16, 2026 •

edited

Loading