Otel library updates#688
Conversation
There was a problem hiding this comment.
If we expect #663 to be difficult or time consuming to digest, review and merge, then I think it would make sense to take this in and rebase #663 on this. If we do that , I think we need to make a small additional otel semconv/schema version synchronization change in this PR to fix the 'incompatible schema' otel error we have in HEAD, too.
| "go.opentelemetry.io/otel/attribute" | ||
| otelresource "go.opentelemetry.io/otel/sdk/resource" | ||
| semconv "go.opentelemetry.io/otel/semconv/v1.37.0" | ||
| semconv "go.opentelemetry.io/otel/semconv/v1.41.0" |
There was a problem hiding this comment.
I think if we make this change, then we also need to bump semconv to the same v1.41.0 in pkg/instrumentation/trace/trace.go. To avoid the 'incompatible schema' error which we have in current HEAD (only fixed in #663).
In my personal view, I would prioritize #663 first and then move with this patch others. |
This PR is not really needed if #663 takes care of the Trivy findings. I will fix the thing pointed out by Krisztian anyway. What I would like is to be able to run the Trivy against a clean main branch preferably today. Whether 663 or 688 gets merged, I don't care at all. |
Signed-off-by: Ukri Niemimuukko <ukri.niemimuukko@intel.com>
|
I think it is better to update #663 to latest versions and get it merged. |
4 participants
This fixes the vulnerability findings reported by Trivy.