-
Notifications
You must be signed in to change notification settings - Fork 72
feat: add internal thinking field to capture model's reasoning output #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: support-multimodal
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ilopezluna, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Ollama HTTP handler by integrating a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The
Message.Thinkingfield is tagged for JSON output but described as an internal field; if this content is meant to remain internal (e.g., for logging or debugging only), consider removing the JSON tag or using a separate non-serialized field to avoid unintentionally exposing reasoning to clients.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `Message.Thinking` field is tagged for JSON output but described as an internal field; if this content is meant to remain internal (e.g., for logging or debugging only), consider removing the JSON tag or using a separate non-serialized field to avoid unintentionally exposing reasoning to clients.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for capturing the model's reasoning output (thinking) in chat responses. The changes are well-implemented, adding a Thinking field to the Message struct and updating the HTTP handler to populate this field for both streaming and non-streaming chat responses. The implementation is consistent with existing patterns for generate responses and includes necessary checks for safety. The code is clear and effectively achieves the goal of the pull request.
updated the Ollama HTTP handler to include thinking support for streaming chat responses